Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(checkpoints): Update block hash checkpoints for mainnet #4919

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

oxarbitrage
Copy link
Contributor

Motivation

Part of the quick fixes of CI timeouts #4910

This PR updates mainnet checkpoints, will do the testnet ones but i have to sync zcashd testnet from scratch first.I will submit them in a separated PR as mainnet is the most important.

Solution

Update mainnet checkpoints

Review

Anyone can review, i think this should be merged if it pass the CI or if it don't.

Follow Up Work

Update testnet checkpoints.

@oxarbitrage oxarbitrage requested a review from a team as a code owner August 18, 2022 18:13
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team August 18, 2022 18:13
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #4919 (795ae91) into main (360631f) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4919      +/-   ##
==========================================
- Coverage   78.86%   78.72%   -0.15%     
==========================================
  Files         309      309              
  Lines       38781    38781              
==========================================
- Hits        30586    30530      -56     
- Misses       8195     8251      +56     

@teor2345
Copy link
Contributor

teor2345 commented Aug 21, 2022

I'm still seeing a timeout in the Zebra update to tip test, even with the updated checkpoints:

2022-08-18T23:00:06.180256Z INFO {net="Main"}: zebrad::components::sync::progress: estimated progress to chain tip sync_percent=99.754% current_height=Height(1773526) network_upgrade=Nu5 remaining_sync_blocks=4378 time_since_last_state_block=0s
Error:
0: stdout of command did not contain any matches for the given regex
Location:
/opt/zebrad/zebra-test/src/command.rs:779
Command:
"/opt/zebrad/target/release/zebrad" "-c" "/tmp/zebrad_testsBaar2c/zebrad.toml" "start"

Match Regex:
[
"finished initial sync to chain tip, using gossiped blocks .sync_percent.=.*100\.",
]

https://github.com/ZcashFoundation/zebra/runs/7918830518?check_suite_focus=true#step:6:143

This is not a blocking change for this PR, but it does block ticket #4910.

@teor2345 teor2345 changed the title add(checkpoints): Mainnet new checkpoints change(checkpoints): Add new checkpoints for mainnet Aug 22, 2022
@teor2345 teor2345 changed the title change(checkpoints): Add new checkpoints for mainnet change(checkpoints): Update block hash checkpoints for mainnet Aug 22, 2022
@teor2345 teor2345 added A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement P-High 🔥 I-slow Problems with performance or responsiveness labels Aug 22, 2022
@teor2345 teor2345 merged commit e5993af into main Aug 22, 2022
@teor2345 teor2345 deleted the update-checkpoints branch August 22, 2022 20:10
@teor2345
Copy link
Contributor

I admin-merged this PR because it's low risk, and multiple CI failures are blocking Mergify.

@teor2345 teor2345 mentioned this pull request Aug 30, 2022
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants