Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for sync test timeouts in CI #4910

Closed
teor2345 opened this issue Aug 15, 2022 · 2 comments · Fixed by #4918
Closed

Quick fix for sync test timeouts in CI #4910

teor2345 opened this issue Aug 15, 2022 · 2 comments · Fixed by #4918
Assignees
Labels
C-bug Category: This is a bug C-testing Category: These are tests I-integration-fail Continuous integration fails, including build and test failures I-slow Problems with performance or responsiveness

Comments

@teor2345
Copy link
Contributor

Motivation

Some of Zebra's sync tests are currently failing in CI on the main branch and other PRs.

Possible Solutions

  • increase the test timeouts
  • update the Zebra checkpoints

We have other open tickets that will fix these performance issues, but we need a quick fix so we can continue working on them.

These failures block almost every zebrad and Zebra DevOps task in this sprint.

@teor2345 teor2345 added C-bug Category: This is a bug S-needs-triage Status: A bug report needs triage P-High 🔥 I-slow Problems with performance or responsiveness I-integration-fail Continuous integration fails, including build and test failures C-testing Category: These are tests labels Aug 15, 2022
@oxarbitrage
Copy link
Contributor

There is an additional problem in the CI related to clippy and the last version of it https://github.com/ZcashFoundation/zebra/pull/4918/checks?check_run_id=7885954690

It seems the problem is in the prost crate. Here someone tries to fix it but didn't worked out: tokio-rs/prost#704
I think they ended up removing clippy at tokio-rs/prost#702 however is hard to tell as they dont explain anything on their pull requests.

If they fix it and tag a release soon we should upgrade prost and probably tonic and tonic-build in the same pull request.

@teor2345
Copy link
Contributor Author

There is an additional problem in the CI related to clippy and the last version of it https://github.com/ZcashFoundation/zebra/pull/4918/checks?check_run_id=7885954690

It seems the problem is in the prost crate. Here someone tries to fix it but didn't worked out: tokio-rs/prost#704 I think they ended up removing clippy at tokio-rs/prost#702 however is hard to tell as they dont explain anything on their pull requests.

They gave up on making clippy pass in their CI, which pushes the work onto downstream users.

But we still want clippy to pass in our CI, so I'll open a PR to fix it tomorrow.
(This is a different bug to CI timeouts, so it should get a different PR.)

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug C-testing Category: These are tests I-integration-fail Continuous integration fails, including build and test failures I-slow Problems with performance or responsiveness
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants