feat(state): Store history trees by height in the non-finalized state

[upbqdn]

Motivation

In order to implement #4824, the non-finalized state needs to store history
trees by their height, so that it can send the history tree corresponding to the
root block to the finalized state when committing the root block.

Solution

This PR adds history_trees_by_height to Chain in the non-finalized state.

Closes #4837.

Follow Up Work

Finish #4721.

[codecov]

Codecov Report

Merging #4928 (2bef36f) into main (4cda4ee) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4928      +/-   ##
==========================================
- Coverage   79.18%   78.95%   -0.24%     
==========================================
  Files         309      309              
  Lines       38783    38789       +6     
==========================================
- Hits        30710    30625      -85     
- Misses       8073     8164      +91     

[teor2345]

Thanks, nice work on the PartialEq refactor.

[upbqdn]

@teor2345 if the CI doesn't pass, do you think you'd be able to merge this manually? It would be handy to have this PR in place for #4721.

[teor2345]

@teor2345 if the CI doesn't pass, do you think you'd be able to merge this manually? It would be handy to have this PR in place for #4721.

I think we've fixed all the outstanding bugs, so I'm hoping that we're done with admin merges.
(And we should really only be skipping CI for high priority PRs.)

Can you start your next PR by rebasing it on the add-hist-trees-by-height branch?
You might want to rebase add-hist-trees-by-height on main first.

If that won't work, here's what I expect will happen with CI:

• PR fix(tests): Update timeout for Zebra sync tests #4918 will pass CI and get merged by Mergify, then
• Other PRs will pass CI once they are rebased on the latest main branch, and
• CI will speed up after the first full sync finishes on main

If PR #4918 fails, you can try doing a @mergifyio update, and increasing the timeouts in that PR, or you can ask @oxarbitrage to fix the PR.

If all that doesn't work out, I'll see what I can do tomorrow morning.

[teor2345]

This PR is a low priority, but I'm marking it with Medium so it merges a bit earlier, so that Marek can use it for other work.

[teor2345]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[gustavovalverde]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated