Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store history trees by height in the non-finalized state #4837

Closed
upbqdn opened this issue Jul 27, 2022 · 1 comment · Fixed by #4928
Closed

Store history trees by height in the non-finalized state #4837

upbqdn opened this issue Jul 27, 2022 · 1 comment · Fixed by #4928
Assignees
@upbqdn
Labels
A-state Area: State / database changes C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness

Comments

@upbqdn
Copy link
Member

upbqdn commented Jul 27, 2022

Motivation

In order to implement #4824, the non-finalized state needs to store history trees by their height, so that it can send the history tree corresponding to the root block to the finalized state when committing the root block.

Related Work

#4824
@upbqdn upbqdn added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-High 🔥 I-slow Problems with performance or responsiveness A-state Area: State / database changes and removed S-needs-triage Status: A bug report needs triage labels Jul 27, 2022
@upbqdn upbqdn self-assigned this Jul 27, 2022
@ftm1000 ftm1000 added S-needs-triage Status: A bug report needs triage and removed S-needs-triage Status: A bug report needs triage labels Jul 28, 2022
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Aug 4, 2022
@upbqdn upbqdn changed the title Store history trees by height in the non-finalized state Store history trees by height to the non-finalized state Aug 22, 2022
@upbqdn upbqdn changed the title Store history trees by height to the non-finalized state Store history trees by height in the non-finalized state Aug 22, 2022
@upbqdn upbqdn mentioned this issue Aug 22, 2022
Merged
@teor2345
Copy link
Contributor

Zebra's performance is good enough for now, so this is a low priority.

@mergify mergify bot closed this as completed in #4928 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@upbqdn upbqdn

Labels
A-state Area: State / database changes C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(state): Store history trees by height in the non-finalized state ZcashFoundation/zebra
3 participants
@upbqdn @teor2345 @ftm1000