-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0 beta.5 release #3586
v1.0.0 beta.5 release #3586
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3586 +/- ##
==========================================
+ Coverage 78.34% 80.14% +1.80%
==========================================
Files 267 276 +9
Lines 31526 32373 +847
==========================================
+ Hits 24698 25946 +1248
+ Misses 6828 6427 -401 |
Thank you for writing this list out, it's very helpful for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Maybe this approval will merge the PR, but that's ok, you can just tag whatever commit it ends up in. We can also fix up the changelog after the tag, if a few extra PRs slipped in.
I added the new PRs that were recently merged into |
Here's a list of crates the versions of which I didn't increment:
I incremented the versions of all other crates. |
I'll try to keep updating this PR until it gets merged. If that doesn't work, I'll stop updating it, wait until it is merged, and then fix the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looking good!
I tested that the exact cargo install command in |
Yep we'll do |
Sure, I posted that to make the review even easier. I'll post both lists by default if I'm doing another release. It doesn't take almost any extra time to create the lists and I think it's beneficial for the review. |
name: Release Checklist Template
about: Checklist of versioning to create a taggable commit for Zebra
title: ''
labels:
assignees: ''
Versioning
Which Crates to Increment
To check if any of the top-level crates need version increments, go to the zebra GitHub code page: https://github.com/ZcashFoundation/zebra and use the last modified dates of each crate. Alternatively you can use the github compare tool and check the
main
branch against the last tag (Example).git diff --stat <previous-release-tag> origin/main
is also useful to see what's changed.zebrad
crate version in thezebra-network
user agent string(currently the constant
USER_AGENT
inzebra-network/src/constants.rs
)README.md
book/src/user/install.md
How to Increment Versions
Zebra follows semantic versioning.
Semantic versions look like:
MAJOR
.MINOR
.PATCH[
-TAG
.PRE-RELEASE]
Pre-Release Crates
Pre-Release versions have a
TAG
like "alpha" or "beta". For example:1.0.0-alpha.0
PRE-RELEASE
version for the crate.Optionally, if a
MINOR
feature pre-release breaksMAJOR
API compatibility:MAJOR
version, and reset all the other versions to zeroUnstable Crates
Unstable versions have a
MAJOR
version of zero. For example:0.1.0
MINOR
version for breaking changesStable Crates
For example:
1.0.0
Increment the first version component in this list, and reset the other components to zero:
Version Locations
Once you know which versions you want to increment, you can find them in the:
Cargo.toml
sCargo.toml
szebra-network
protocol user agent: https://github.com/ZcashFoundation/zebra/blob/main/zebra-network/src/constants.rsREADME.md
book/src/user/install.md
Cargo.lock
: automatically generated bycargo build
Version Tooling
You can use
fastmod
to interactively find and replace versions.For example, you can do something like:
Reviewing Version Bumps
Check for missed changes by going to:
https://github.com/ZcashFoundation/zebra/tree/<commit-hash>/
Where
<commit-hash>
is the hash of the last commit in the version bump PR.If any Zebra or Tower crates have commit messages that are not a version bump, we have missed an update.
Also check for crates that depend on crates that have changed. They should get a version bump as well.
Initial Testing
cargo install
command in works. Usee.g.
cargo install --locked --path zebrad
.README
As we resolve various outstanding known issues and implement new functionality with each release, we should double check the README for any necessary updates.
We should check and update if necessary:
to ensure that any items that are resolved in the latest release are no longer listed in the README.
Change Log
Important: Any merge into
main
deletes any edits to the draft changelog. Once you are ready to tag a release, copy the draft changelog intoCHANGELOG.md
.We follow the Keep a Changelog format.
We use the Release Drafter workflow to automatically create a draft changelog.
To create the final change log:
CHANGELOG.md
Change Categories
From "Keep a Changelog":
Added
for new features.Changed
for changes in existing functionality.Deprecated
for soon-to-be removed features.Removed
for now removed features.Fixed
for any bug fixes.Security
in case of vulnerabilities.Create the release PR
After you have the version increments and the updated changelog,
(name suggestion, example:
v1.0.0-alpha.0-release
)&template=release-checklist.md
to thecomparing url (Example).
since you created the PR to update
CHANGELOG.md
and push any updates if necessaryusing the draft release as a base, by clicking the Edit icon
in the draft release.
Zebra
followed by the version tag, for example:Zebra 1.0.0-alpha.0
(starting just after the title
## [Zebra ...
)v1.0.0-alpha.0
main
branchFinal Testing
cargo install
command inREADME.md
works (--git
behaves a bit differently to--path
)If the build fails after tagging:
README.md
with a new git tagCHANGELOG.md
with details about the fix