Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 beta.5 release #3586

Merged
merged 7 commits into from
Feb 21, 2022
Merged

v1.0.0 beta.5 release #3586

merged 7 commits into from
Feb 21, 2022

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Feb 18, 2022


name: Release Checklist Template
about: Checklist of versioning to create a taggable commit for Zebra
title: ''
labels:
assignees: ''


Versioning

Which Crates to Increment

To check if any of the top-level crates need version increments, go to the zebra GitHub code page: https://github.com/ZcashFoundation/zebra and use the last modified dates of each crate. Alternatively you can use the github compare tool and check the main branch against the last tag (Example). git diff --stat <previous-release-tag> origin/main is also useful to see what's changed.

  • Increment the crates that have new commits since the last version update
  • Increment any crates that depend on crates that have changed
  • Use the zebrad crate version in the zebra-network user agent string
    (currently the constant USER_AGENT in zebra-network/src/constants.rs)
  • Use the latest git tag in README.md
  • Use the latest git tag in book/src/user/install.md

How to Increment Versions

Zebra follows semantic versioning.

Semantic versions look like: MAJOR.MINOR.PATCH[-TAG.PRE-RELEASE]

Pre-Release Crates

Pre-Release versions have a TAG like "alpha" or "beta". For example: 1.0.0-alpha.0

  1. Increment the PRE-RELEASE version for the crate.

Optionally, if a MINOR feature pre-release breaks MAJOR API compatibility:

  1. Increment the MAJOR version, and reset all the other versions to zero

Unstable Crates

Unstable versions have a MAJOR version of zero. For example: 0.1.0

  1. Follow stable crate versioning, but increment the MINOR version for breaking changes

Stable Crates

For example: 1.0.0

Increment the first version component in this list, and reset the other components to zero:

  1. MAJOR versions for breaking public API changes and removals
    • check for types from dependencies that appear in the public API
  2. MINOR versions for new features
  3. PATCH versions for bug fixes
    • includes dependency updates that don't impact the public API

Version Locations

Once you know which versions you want to increment, you can find them in the:

Version Tooling

You can use fastmod to interactively find and replace versions.

For example, you can do something like:

fastmod --extensions rs,toml,md --fixed-strings '1.0.0-alpha.12' '1.0.0-alpha.13'
fastmod --extensions rs,toml,md --fixed-strings '0.2.9' '0.2.10' tower-batch
fastmod --extensions rs,toml,md --fixed-strings '0.2.8' '0.2.9' tower-fallback

Reviewing Version Bumps

Check for missed changes by going to:
https://github.com/ZcashFoundation/zebra/tree/<commit-hash>/
Where <commit-hash> is the hash of the last commit in the version bump PR.

If any Zebra or Tower crates have commit messages that are not a version bump, we have missed an update.

Also check for crates that depend on crates that have changed. They should get a version bump as well.

Initial Testing

  • After any changes, test that the cargo install command in works. Use
    e.g. cargo install --locked --path zebrad.

README

As we resolve various outstanding known issues and implement new functionality with each release, we should double check the README for any necessary updates.

We should check and update if necessary:

  • The "Beta Release" section
  • The "Known Issues" section

to ensure that any items that are resolved in the latest release are no longer listed in the README.

Change Log

Important: Any merge into main deletes any edits to the draft changelog. Once you are ready to tag a release, copy the draft changelog into CHANGELOG.md.

We follow the Keep a Changelog format.

We use the Release Drafter workflow to automatically create a draft changelog.

To create the final change log:

  • Copy the draft changelog into CHANGELOG.md
  • Delete any trivial changes
  • Combine duplicate changes
  • Edit change descriptions so they are consistent, and make sense to non-developers
  • Check the category for each change
    • prefer the "Fix" category if you're not sure

Change Categories

From "Keep a Changelog":

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Create the release PR

After you have the version increments and the updated changelog,

  • Push the version increments and the updated changelog into a branch
    (name suggestion, example: v1.0.0-alpha.0-release)
  • Create a release PR by adding &template=release-checklist.md to the
    comparing url (Example).
  • While the PR is being reviewed, keep track of any PRs that have been merged
    since you created the PR to update CHANGELOG.md and push any updates if necessary
  • Once the release PR has been approved and merged, create a new release
    using the draft release as a base, by clicking the Edit icon
    in the draft release.
  • Set the release title to Zebra followed by the version tag, for example:
    Zebra 1.0.0-alpha.0
  • Copy the final changelog of this release to the release description
    (starting just after the title ## [Zebra ...)
  • Set the tag name to the version tag, for example: v1.0.0-alpha.0
  • Set the release to target the main branch
  • Mark the release as 'pre-release' (until we are no longer alpha/beta)
  • Publish the release

Final Testing

  • After tagging the release, test that the exact cargo install command in
    README.md works (--git behaves a bit differently to --path)

If the build fails after tagging:

  1. fix the build
  2. check if the fixes changed any extra crates, and do the required version increments
  3. update README.md with a new git tag
  4. update CHANGELOG.md with details about the fix
  5. tag a new release

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #3586 (9e58a2f) into main (499ae89) will increase coverage by 1.80%.
The diff coverage is 75.11%.

@@            Coverage Diff             @@
##             main    #3586      +/-   ##
==========================================
+ Coverage   78.34%   80.14%   +1.80%     
==========================================
  Files         267      276       +9     
  Lines       31526    32373     +847     
==========================================
+ Hits        24698    25946    +1248     
+ Misses       6828     6427     -401     

@teor2345
Copy link
Contributor

I've excluded these PRs:

Thank you for writing this list out, it's very helpful for reviewing!

teor2345
teor2345 previously approved these changes Feb 21, 2022
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Maybe this approval will merge the PR, but that's ok, you can just tag whatever commit it ends up in. We can also fix up the changelog after the tag, if a few extra PRs slipped in.

@upbqdn
Copy link
Member Author

upbqdn commented Feb 21, 2022

I added the new PRs that were recently merged into main.

@upbqdn
Copy link
Member Author

upbqdn commented Feb 21, 2022

Here's a list of crates the versions of which I didn't increment:

  • zebra-client
  • zebra-rpc.

I incremented the versions of all other crates.

@upbqdn
Copy link
Member Author

upbqdn commented Feb 21, 2022

I'll try to keep updating this PR until it gets merged. If that doesn't work, I'll stop updating it, wait until it is merged, and then fix the changelog.

Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looking good!

mergify bot added a commit that referenced this pull request Feb 21, 2022
@mergify mergify bot merged commit 2253f01 into main Feb 21, 2022
@mergify mergify bot deleted the v1.0.0-beta.5-release branch February 21, 2022 14:29
@upbqdn
Copy link
Member Author

upbqdn commented Feb 21, 2022

I tested that the exact cargo install command in README.md works smoothly with the new release. All should be done now.

@teor2345
Copy link
Contributor

Here's a list of crates the versions of which I didn't increment:

  • zebra-client
  • zebra-rpc.

I incremented the versions of all other crates.

Yep we'll do zebra-rpc and the new sync crate at the next release.

@upbqdn
Copy link
Member Author

upbqdn commented Feb 22, 2022

Sure, I posted that to make the review even easier. I'll post both lists by default if I'm doing another release. It doesn't take almost any extra time to create the lists and I think it's beneficial for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants