Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use string literal to format unreachable message #3479

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Use string literal to format unreachable message #3479

merged 1 commit into from
Feb 8, 2022

Conversation

dconnolly
Copy link
Contributor

Motivation

On nightly this is being enforced, causing our nightly-dependent coverage job to fail.

Solution

Do what rustc says, and supply a string literal to format the item passed to unreachable!.

Review

Anyone can review

Reviewer Checklist

  • Fixes Coverage job

@dconnolly dconnolly added A-rust Area: Updates to Rust code P-High 🔥 labels Feb 8, 2022
@dconnolly dconnolly self-assigned this Feb 8, 2022
@dconnolly dconnolly requested review from a team, conradoplg, gustavovalverde and teor2345 and removed request for conradoplg February 8, 2022 04:24
teor2345
teor2345 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I thought it might be more complicated than this.

I wonder if this is the only instance, I guess we'll find out from CI.

@teor2345 teor2345 added the C-cleanup Category: This is a cleanup label Feb 8, 2022
@mergify mergify bot merged commit 3644171 into main Feb 8, 2022
@mergify mergify bot deleted the fix-unreachable-formatting-on-nightly branch February 8, 2022 05:56
@teor2345 teor2345 mentioned this pull request Feb 8, 2022
Merged
1 task
@upbqdn upbqdn mentioned this pull request Feb 18, 2022
Merged
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@gustavovalverde gustavovalverde Awaiting requested review from gustavovalverde

Assignees

@dconnolly dconnolly

Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconnolly @teor2345