Use string literal to format unreachable message in test #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
added
A-rust
|
@gustavovalverde we missed this change in #3479 because coverage is an optional check. And maybe because the build didn't continue after errors. We might want to think about changing those settings, if these kind of CI failures become more common. But it's not urgent at all. |
teor2345
reviewed
Feb 8, 2022
teor2345
reviewed
Feb 8, 2022
teor2345
approved these changes
Feb 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #3483 +/- ##
==========================================
+ Coverage 78.34% 78.47% +0.13%
==========================================
Files 267 273 +6
Lines 31526 31814 +288
==========================================
+ Hits 24698 24967 +269
- Misses 6828 6847 +19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Missed one in the tests
Solution
Use string literal to format unreachable message
Review
Anyone can review
Reviewer Checklist