Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include listing not-mentioned PRs and not-bumped crates in the release checklist #3621

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

conradoplg
Copy link
Collaborator

Motivation

In #3586 (comment) @upbqdn had a great idea of listing the PRs that were removed from the changelog and the crates that haven't been incremented, which makes reviewing easier. So I thought we could include this in the checklist.

Specifications

Designs

Solution

Review

Not urgent. Anyone can review. This was unprompted, so feel free to give feedback on whether we should do this or to suggest something different.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for these improvements.

mergify bot added a commit that referenced this pull request Feb 23, 2022
@mergify mergify bot merged commit e75fe2c into main Feb 23, 2022
@mergify mergify bot deleted the improve-release-checklist branch February 23, 2022 18:18
@oxarbitrage oxarbitrage mentioned this pull request Mar 25, 2022
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants