Validate funding stream addresses #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
oxarbitrage
commented
Nov 8, 2021
3 tasks
|
I synchronized zebra up to tip based with this PR. |
|
I'd like @jvff to do the initial review on this PR. |
jvff
suggested changes
Nov 11, 2021
There was a problem hiding this comment.
It's looking good, there's only one blocker. I'm not completely sure, but I think that maybe the values should be checked to match their intended receiver.
Besides that, I ended up adding a bunch of suggestions and ideas, but don't let those block you, we can ignore them and revisit later if needed 😁
teor2345
reviewed
Nov 12, 2021
teor2345
reviewed
Nov 12, 2021
Co-authored-by: Janito Vaqueiro Ferreira Filho <[email protected]>
Co-authored-by: Janito Vaqueiro Ferreira Filho <[email protected]>
Co-authored-by: teor <[email protected]>
mpguerra
added a commit
that referenced
this pull request
May 19, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2023
* ZIPs were updated to remove ambiguity, this was tracked in #1267. * #2105 was fixed by #3039 and #2379 was closed by #3069 * #2230 was a duplicate of #2231 which was closed by #2511 * #3235 was obsoleted by #2156 which was fixed by #3505 * #1850 was fixed by #2944, #1851 was fixed by #2961 and #2902 was fixed by #2969 * We migrated to Rust 2021 edition in Jan 2022 with #3332 * #1631 was closed as not needed * #338 was fixed by #3040 and #1162 was fixed by #3067 * #2079 was fixed by #2445 * #4794 was fixed by #6122 * #1678 stopped being an issue * #3151 was fixed by #3934 * #3204 was closed as not needed * #1213 was fixed by #4586 * #1774 was closed as not needed * #4633 was closed as not needed * Clarify behaviour of difficulty spacing Co-authored-by: teor <[email protected]> * Update comment to reflect implemented behaviour Co-authored-by: teor <[email protected]> * Update comment to reflect implemented behaviour when retrying block downloads Co-authored-by: teor <[email protected]> * Update `TODO` to remove closed issue and clarify when we might want to fix Co-authored-by: teor <[email protected]> * Update `TODO` to remove closed issue and clarify what we might want to change in future Co-authored-by: teor <[email protected]> * Clarify benefits of how we do block verification Co-authored-by: teor <[email protected]> * Fix rustfmt errors --------- Co-authored-by: teor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to validate the coinbase output addresses against the funding stream receivers. Close #338
Specifications
https://zips.z.cash/protocol/protocol.pdf#fundingstreams
https://zips.z.cash/protocol/protocol.pdf#zip214fundingstreams
Solution
This is based on #1170 where we had a draft PR to validate the founders reward addresses. The funding streams is similar so some concepts are taken from there adapting it for funding streams and making other improvements.
Review
@teor4321 and/or @jvff
Reviewer Checklist
Follow Up Work
With thisn in place we can validate the consensus rules related to miner rewards as they are the reminder of the block subsidy minus all the funding streams. #1162