Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store transactions in a separate database index #3151

Closed
Tracked by #3134
mpguerra opened this issue Dec 3, 2021 · 1 comment · Fixed by #3934
Closed
Tracked by #3134

Store transactions in a separate database index #3151

mpguerra opened this issue Dec 3, 2021 · 1 comment · Fixed by #3934
Assignees
@teor2345
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement lightwalletd any work associated with lightwalletd

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Dec 3, 2021 •
edited by teor2345
Loading

Motivation

lightwalletd caches all the blocks from Sapling activation, asking for them in height order. So the block RPC needs to be fast.

Designs

https://github.com/ZcashFoundation/zebra/blob/main/book/src/dev/rfcs/0005-state-updates.md#rocksdb-data-structures

For good performance, use the RocksDB multi_get methods to get all the transactions for a block.

Tasks

  1. Make the changes
  2. Increment the database version
  3. If you created new Rust modules, make sure the regenerate state paths are up to date in https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/test.yml
@mpguerra mpguerra mentioned this issue Dec 3, 2021
Closed
33 tasks
@teor2345 teor2345 mentioned this issue Dec 6, 2021
Merged
2 tasks
@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement labels Feb 8, 2022
@teor2345 teor2345 mentioned this issue Feb 8, 2022
Merged
@ftm1000 ftm1000 added the S-needs-triage Status: A bug report needs triage label Feb 10, 2022
@dconnolly
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @jvff @oxarbitrage @teor2345 @upbqdn

This was referenced Feb 17, 2022
Merged
Merged
Merged
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Feb 21, 2022
This was referenced Feb 22, 2022
Merged
Merged
Closed
This was referenced Mar 2, 2022
Merged
Merged
Merged
Merged
@teor2345 teor2345 self-assigned this Mar 9, 2022
@teor2345 teor2345 mentioned this issue Mar 15, 2022
Merged
3 tasks
@ftm1000 ftm1000 added the lightwalletd any work associated with lightwalletd label Mar 16, 2022
@teor2345 teor2345 mentioned this issue Mar 22, 2022
Merged
3 tasks
@mergify mergify bot closed this as completed in #3934 Apr 7, 2022
@arya2 arya2 mentioned this issue Mar 31, 2023
Merged
6 tasks
@mpguerra mpguerra mentioned this issue Apr 11, 2023
Closed
4 tasks
mpguerra added a commit that referenced this issue May 19, 2023
@mpguerra
#3151 was fixed by #3934
3bdf2cf
mergify bot pushed a commit that referenced this issue May 23, 2023
@mpguerra @teor2345
Delete outdated TODOs refering to closed issues (#6732)
ec2e9ca 
* ZIPs were updated to remove ambiguity, this was tracked in #1267.

* #2105 was fixed by #3039 and #2379 was closed by #3069

* #2230 was a duplicate of #2231 which was closed by #2511

* #3235 was obsoleted by #2156 which was fixed by #3505

* #1850 was fixed by #2944, #1851 was fixed by #2961 and #2902 was fixed by #2969

* We migrated to Rust 2021 edition in Jan 2022 with #3332

* #1631 was closed as not needed

* #338 was fixed by #3040 and #1162 was fixed by #3067

* #2079 was fixed by #2445

* #4794 was fixed by #6122

* #1678 stopped being an issue

* #3151 was fixed by #3934

* #3204 was closed as not needed

* #1213 was fixed by #4586

* #1774 was closed as not needed

* #4633 was closed as not needed

* Clarify behaviour of difficulty spacing

Co-authored-by: teor <[email protected]>

* Update comment to reflect implemented behaviour

Co-authored-by: teor <[email protected]>

* Update comment to reflect implemented behaviour when retrying block downloads

Co-authored-by: teor <[email protected]>

* Update `TODO` to remove closed issue and clarify when we might want to fix

Co-authored-by: teor <[email protected]>

* Update `TODO` to remove closed issue and clarify what we might want to change in future

Co-authored-by: teor <[email protected]>

* Clarify benefits of how we do block verification

Co-authored-by: teor <[email protected]>

* Fix rustfmt errors

---------

Co-authored-by: teor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
4 participants
@dconnolly @mpguerra @teor2345 @ftm1000