Enforce Rust edition 2021 #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3332 +/- ##
==========================================
- Coverage 78.02% 77.88% -0.14%
==========================================
Files 266 266
Lines 31483 31447 -36
==========================================
- Hits 24564 24494 -70
- Misses 6919 6953 +34 |
jvff
approved these changes
Jan 12, 2022
|
Mmm...this must have been captured by Mergify, as all the conditions are met. If possible, please do not merge it manually so I can check what's going on. |
Is it because there are two reviewers in the PR, and only one approval? |
conradoplg
approved these changes
Jan 13, 2022
|
@Mergifyio refresh |
✅ Pull request refreshed |
2 tasks
mpguerra
added a commit
that referenced
this pull request
May 19, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2023
* ZIPs were updated to remove ambiguity, this was tracked in #1267. * #2105 was fixed by #3039 and #2379 was closed by #3069 * #2230 was a duplicate of #2231 which was closed by #2511 * #3235 was obsoleted by #2156 which was fixed by #3505 * #1850 was fixed by #2944, #1851 was fixed by #2961 and #2902 was fixed by #2969 * We migrated to Rust 2021 edition in Jan 2022 with #3332 * #1631 was closed as not needed * #338 was fixed by #3040 and #1162 was fixed by #3067 * #2079 was fixed by #2445 * #4794 was fixed by #6122 * #1678 stopped being an issue * #3151 was fixed by #3934 * #3204 was closed as not needed * #1213 was fixed by #4586 * #1774 was closed as not needed * #4633 was closed as not needed * Clarify behaviour of difficulty spacing Co-authored-by: teor <[email protected]> * Update comment to reflect implemented behaviour Co-authored-by: teor <[email protected]> * Update comment to reflect implemented behaviour when retrying block downloads Co-authored-by: teor <[email protected]> * Update `TODO` to remove closed issue and clarify when we might want to fix Co-authored-by: teor <[email protected]> * Update `TODO` to remove closed issue and clarify what we might want to change in future Co-authored-by: teor <[email protected]> * Clarify benefits of how we do block verification Co-authored-by: teor <[email protected]> * Fix rustfmt errors --------- Co-authored-by: teor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've wanted to comply with Rust 2021 edition for a bit:
#2709
Solution
Upgraded the
Cargo.tomls toedition = 2021, did a littlecargo fix --editionin each crate, ran tests, did a littleclippy fix, and only had to tweak a few lines. 🎉Resolves #2709
Review
Anyone can review, maybe @jvff @conradoplg
Reviewer Checklist