Validate funding stream addresses #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
commented
Nov 7, 2021
3 tasks
teor2345
reviewed
Nov 8, 2021
Comment on lines
+129
to
+132
| address_hash = address_hash[2..22].to_vec(); | ||
| address_hash.insert(0, OpCode::Push20Bytes as u8); | ||
| address_hash.insert(0, OpCode::Hash160 as u8); | ||
| address_hash.insert(address_hash.len(), OpCode::Equal as u8); |
There was a problem hiding this comment.
It feels a bit weird to be doing this in Rust, when the rest of our script validation happens in zcash_script, which calls zcashd's C++ implementation. But adding another unsafe C++ function could be complicated, and it's more risky. (And this function might not even exist in zcashd.)
So I think this code is simple enough to re-implement. We just need to test it carefully.
Are there any zcashd test vectors we could use?
|
Replaced by ZcashFoundation#3040 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to validate the coinbase output addresses against the funding stream receivers. Part of ZcashFoundation#338
Specifications
[TBA]
Designs
[TBA]
Solution
This is based on ZcashFoundation#3017 and it still needs a bunch of work. It is published so we can have the big picture of all we need to get done.
It needs adjustments in almost all calls and further test coverage. Right now it is passing test blocks and a quick test will be to sync up to tip however i didnt made this yet as the code is constantly changed.
Review
Will be useful for @teor4321 as they are reviewing ZcashFoundation#3017
Reviewer Checklist
Follow Up Work