Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full synchronization test times out in CI #4155

Closed
jvff opened this issue Apr 20, 2022 · 2 comments · Fixed by #4212
Closed

Full synchronization test times out in CI #4155

jvff opened this issue Apr 20, 2022 · 2 comments · Fixed by #4212
Assignees
Labels
A-infrastructure Area: Infrastructure changes C-enhancement Category: This is an improvement C-testing Category: These are tests

Comments

@jvff
Copy link
Contributor

jvff commented Apr 20, 2022

Motivation

The full chain synchronization test is currently timing out in CI. We should find a way to speed up synchronization so that it doesn't time out.

@jvff jvff added A-infrastructure Area: Infrastructure changes C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-High 🔥 C-testing Category: These are tests labels Apr 20, 2022
@jvff
Copy link
Contributor Author

jvff commented Apr 20, 2022

One possible solution is to:

@teor2345
Copy link
Contributor

teor2345 commented Apr 21, 2022

Some other possible solutions are:

Quick tweaks, likely to help

Quick tweaks, likely to help, might cause bugs on slower networks

Quick tweaks, might help

Out of scope

Needs separate tickets, priorities, scheduling:

Larger changes, likely to help

  • move hash calculation and signature verification to a blocking thread, so they don't block network futures
    • we should only do this if the similar disk writes change helps
  • profiling to see where Zebra is waiting - tokio-console Integrate tokio-console #2112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infrastructure Area: Infrastructure changes C-enhancement Category: This is an improvement C-testing Category: These are tests
Projects
None yet
5 participants