feat(ci): validate state version with cached state #4074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Test workflow we were using a different approach than the one being used in the Full sync test. Also, in the Full sync test the variable was LOWER_NET_NAME, but NETWORK was being used in the disk name, with caps.
Disk states synced to canopy and synced to the chain tip should have different names to reference correctly on actual and coming tests the needed disk.
Before building and pushing new cached states, validate that our local version is not lower than the one available in GCP
gustavovalverde
added
A-infrastructure
Co-authored-by: Deirdre Connolly <[email protected]>
…to fix-disk-naming
This reverts commit cbbfaf4.
If we're changing constants.rs we might need to rebuild disks instead of using the cached ones available in GCP
teor2345
reviewed
Apr 10, 2022
|
@teor2345 I've integrated the considerations from your last comment. |
teor2345
reviewed
Apr 19, 2022
|
Regenerate stateful disks failed with #3991:
I'll restart the job. |
teor2345
previously approved these changes
Apr 20, 2022
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
This can't be merged until we fix #4155 |
|
Please include the clean fix #4206 when next updating this branch. |
|
This isn't in the critical path for lightwalletd work, we can merge it after we get the lightwalletd integration tests working. |
gustavovalverde
force-pushed
the
feat-state-versioning
branch
from
6b1ad4e to
c47cccb
Compare
|
Obsoleted by #4271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We don't check the state version when updating the cached state, so old PRs can add a new "latest" cached state with the old state version. This won't break CI, but it adds 2.5 hours to the mergify queue.
We can check cached state version vs the version in the current branch being tested. Doing this requires making the cached state version easier to find in CI. One idea is adding the state version as disk image metadata or in the name of the disk, and then doing some Rust test / grep check to compare the latest cached state disk version with the in-branch version, and only using the cached state if they are the same version.
If the cached state version is higher than the branch version, we can not run the test, failing the test until the branch is rebased onto
main.Either way, the goal is that 'old' state versions (older than the version of state on #main) should not be created and pushed to gcloud, where they can be used by other tests.
Fixes #3881
Depends-On: #4073
Solution
Review
@dconnolly can review this
Follow Up Work
cached state versionis lower than thebranch version