Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(verifier): Update Zebra's block hash checkpoints #4183

Merged
merged 3 commits into from
Apr 25, 2022
Merged

change(verifier): Update Zebra's block hash checkpoints #4183

merged 3 commits into from
Apr 25, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

In #4155, we want to update Zebra's checkpoints, so the initial sync is faster.

Solution

  • Update mainnet checkpoints
  • Update testnet checkpoints, including NU5 re-activation

Related fixes:

  • Update the zebra-checkpoints docs

Review

Anyone can review this PR, it's urgent, because #4155 is blocking a bunch of other tickets.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

teor2345 added 2 commits April 25, 2022 11:42
@teor2345
Update zebra-checkpoints docs for new default checkpoint config
d8a9617 
Also:
- update commands
- link to the spec definition of settled network upgrades
@teor2345
Update mainnet checkpoints
cafcf9c
@teor2345 teor2345 added A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd labels Apr 25, 2022
@teor2345 teor2345 requested a review from a team as a code owner April 25, 2022 01:48
@teor2345 teor2345 self-assigned this Apr 25, 2022
@teor2345 teor2345 requested review from upbqdn and removed request for a team April 25, 2022 01:48
@teor2345 teor2345 changed the title change(verify): Update Zebra's block hash checkpoints change(verifier): Update Zebra's block hash checkpoints Apr 25, 2022
@teor2345
Copy link
Contributor Author

I'm running a full sync test here:

We should merge this PR regardless of the results, but hopefully it will be a bit shorter than 6 hours.

@teor2345 teor2345 requested review from oxarbitrage and removed request for upbqdn April 25, 2022 06:24
This was referenced Apr 25, 2022
Merged
Closed
Merged
mergify bot added a commit that referenced this pull request Apr 25, 2022
@mergify
Merge of #4183
339ba1a
@mergify mergify bot mentioned this pull request Apr 25, 2022
Closed
40 tasks
@mergify mergify bot merged commit 0544076 into main Apr 25, 2022
@mergify mergify bot deleted the update-checkpoints branch April 25, 2022 14:43
@teor2345
Copy link
Contributor Author

We should merge this PR regardless of the results, but hopefully it will be a bit shorter than 6 hours.

The new checkpoints finished the sync in 5h53m, before the checkpoints it was 5h58m.

But container name lookup and image creation pushed the GitHub job over 6 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@teor2345 teor2345

Labels
A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @oxarbitrage