Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(perf): Decrease the request timeout to 15 seconds, to speed up the initial sync #4213

Closed
wants to merge 2 commits into from

Conversation

teor2345
Copy link
Contributor

Motivation

In #4155, we want to speed up Zebra's initial sync.

One way to do that is to give up sooner when peers are slow to respond.

Solution

  • Decrease the peer request timeout to 15 seconds

Review

Anyone can review this PR.

If it makes the sync faster, we should merge it, and open a ticket for a longer-term solution.
If it doesn't make the sync faster, we should close it.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

  • open a ticket for a longer-term solution

@teor2345 teor2345 added C-enhancement Category: This is an improvement P-High 🔥 I-slow Problems with performance or responsiveness A-network Area: Network protocol updates or fixes lightwalletd any work associated with lightwalletd labels Apr 27, 2022
@teor2345 teor2345 self-assigned this Apr 27, 2022
@teor2345
Copy link
Contributor Author

I'm running a full sync test here:
https://github.com/ZcashFoundation/zebra/actions/runs/2230497507

The time to beat is 5h47m.

@teor2345
Copy link
Contributor Author

Full sync took 5h45m, which is exactly the same speed.

@teor2345 teor2345 closed this Apr 28, 2022
@teor2345 teor2345 deleted the shorter-req-timeout branch September 5, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant