-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase block validation timeouts #4156
Conversation
Avoid block validation failures because UTXOs aren't available on time.
Attempt to reduce the synchronization restarts and consequently improve performance.
This could be a bug in the recently merged PR #4149, or an intermittent error:
https://github.com/ZcashFoundation/zebra/runs/6103901143?check_suite_focus=true#step:7:95 Maybe @gustavovalverde can help diagnose? |
This did not lead to a performance increase that's enough to solve the issue (#4155). This PR can be closed, but it might be useful for reference because it contains the workaround I used when synchronization gets stuck on a single block. This can happen on debug builds or on release builds using trace-level logging. It could also happen on some lower-end computers. |
I'd like to fix this bug for low-end computers, if we can do it without breaking the full sync test. Can we leave this PR in draft, fix the sync speed, and then re-test to make sure it doesn't make the sync worse? |
@Mergifyio update |
✅ Branch has been successfully updated |
I am updating this branch to delete the clean action, which causes other actions to fail. |
@Mergifyio update |
✅ Branch has been successfully updated |
I'm running a full sync test here: If it takes around 5h50m, we should merge this PR, because it fixes part of the bug in PR #4286. |
So the full sync tests was skipped, can we relaunch this to check how much time it takes ? |
The test I ran manually took 5h47m, so it is about the same speed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required to fix bugs like #4286.
Motivation
The full synchronization test currently times out after running for 6 hours. One possible cause is that during synchronization the block validation may time out a few times, which leads to a few minutes of delays.
Solution
Increase the UTXO lookup timeout and the block validation time out to see if the synchronization finishes earlier.
Review
Reviewer Checklist
Follow Up Work