-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add major alarm as separate MotionNotReadyCode value #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge with Yaskawa-Global/motoros2#298
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that this conflicts with #17. We'll need to rebase after merging that.
@ted-miller wrote:
while this is true, I'd suggest we merge this one first, as it's a relatively simple change and the corresponding Yaskawa-Global/motoros2#298 was just merged. |
bc7716e
to
fc41380
Compare
Merging at Jimmy's request. He implemented the change requested by gavanderhoorn. |
Prerequisite for motoros2 pr to be merged (as is)