New MotionNotReady codes and strings #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Required for Yaskawa-Global/motoros2#265 |
|
This looks fine. We'll keep this open until Yaskawa-Global/motoros2#265 is fully resolved and we're clear on the process for merging this while keeping other repos in sync (#18) |
…y codes to match with new codes in motoros2 repo
jimmy-mcelwain
force-pushed
the
Additional_MotionNotReady_Codes
branch
from
3a223f9
to
55d63b1
Compare
|
Rebased on main after conflict with #23 |
gavanderhoorn
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
We can probably merge this, without Yaskawa-Global/motoros2#265 getting merged immediately.
After this is merged, we can cut a new release here, update micro_ros_motoplus and then fix CI over at Yaskawa-Global/motoros2.
PR for new release: #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MotionNotReady codes and strings have been added in to clarify error messages. Also changed wording on cycle mode to match what the user sees