Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog (0.1.3) #277

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Update changelog (0.1.3) #277

merged 1 commit into from
Aug 1, 2024

Conversation

gavanderhoorn
Copy link
Collaborator

Preparation for the 0.1.3 release.

See discussion in Yaskawa-Global/motoros2_interfaces#20 on whether we should include #265 (and related Yaskawa-Global/motoros2_interfaces#17).

CHANGELOG.md Outdated Show resolved Hide resolved
@gavanderhoorn gavanderhoorn changed the title Update changelog (0.1.2) Update changelog (0.1.3) Jul 10, 2024
@gavanderhoorn gavanderhoorn added this to the 0.1.3 milestone Jul 10, 2024
@gavanderhoorn
Copy link
Collaborator Author

@ted-miller: I've created a draft release of 0.1.3pre on the Releases page.

Would you (or @yai-rosejo or @jimmy-mcelwain) perhaps have some time to test the binaries there?

I've tested YRC1, Humble.

@ted-miller
Copy link
Collaborator

I'll plan on testing this and #182 first thing Friday.

Also, I believe Jimmy has been working on something that should automate some of the testing. It'll be a good opportunity to give it a try.

CHANGELOG.md Outdated Show resolved Hide resolved
@ted-miller
Copy link
Collaborator

I know we've been testing YRC during development. So I switched to DX200 and it's working well.

@gavanderhoorn
Copy link
Collaborator Author

Have you tested only Humble, or also the Galactic and Foxy builds?

@ted-miller
Copy link
Collaborator

I have just been testing humble. I thought we were just going to let galactic/foxy break whenever they break

@gavanderhoorn
Copy link
Collaborator Author

gavanderhoorn commented Jul 12, 2024

We are, but I'm thinking 'break' as in: if the build breaks (fi because we're using newer API from micro-ROS which doesn't exist in Foxy or Galactic), that's it. We won't spend effort fixing it anymore.

But if we're releasing binaries with updated micro_ros_motoplus builds, we should probably make sure those still work.

@gavanderhoorn
Copy link
Collaborator Author

Would you (or one of your colleagues) have time to check Foxy and/or Galactic as well @ted-miller?

@ted-miller
Copy link
Collaborator

Probably this week.
It's on my todo list.

@ted-miller
Copy link
Collaborator

@jimmy-mcelwain showed me his automated testing app today. It looks like it does a good job of covering (almost) all the topics, services, and action. I have asked him to go ahead and run it against a Foxy and Galactic build.

@gavanderhoorn
Copy link
Collaborator Author

Great.

@jimmy-mcelwain: please share the results of your tests here. I'll finish the release process if things work as they should.

@jimmy-mcelwain
Copy link
Collaborator

@gavanderhoorn everything appears to be working as intended

@gavanderhoorn gavanderhoorn marked this pull request as ready for review July 29, 2024 14:27
@gavanderhoorn gavanderhoorn marked this pull request as draft July 29, 2024 14:32
@gavanderhoorn

This comment was marked as outdated.

@gavanderhoorn gavanderhoorn marked this pull request as ready for review July 29, 2024 14:36
@gavanderhoorn
Copy link
Collaborator Author

gavanderhoorn commented Jul 29, 2024

It's actually ready, we'll add commits for the release proper later.


Edit: @yai-rosejo: I also tagged you as you've contributed to this release. Please let me know whether you agree with the changelog additions.

@gavanderhoorn
Copy link
Collaborator Author

@yai-rosejo: do you have any comments?

Copy link
Collaborator

@yai-rosejo yai-rosejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gavanderhoorn gavanderhoorn merged commit 6332f5d into main Aug 1, 2024
6 checks passed
@gavanderhoorn gavanderhoorn deleted the update_changelog branch August 1, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants