-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog (0.1.3) #277
Conversation
ba74548
to
08b0591
Compare
@ted-miller: I've created a draft release of Would you (or @yai-rosejo or @jimmy-mcelwain) perhaps have some time to test the binaries there? I've tested YRC1, Humble. |
I'll plan on testing this and #182 first thing Friday. Also, I believe Jimmy has been working on something that should automate some of the testing. It'll be a good opportunity to give it a try. |
I know we've been testing YRC during development. So I switched to DX200 and it's working well. |
Have you tested only Humble, or also the Galactic and Foxy builds? |
I have just been testing humble. I thought we were just going to let galactic/foxy break whenever they break |
We are, but I'm thinking 'break' as in: if the build breaks (fi because we're using newer API from micro-ROS which doesn't exist in Foxy or Galactic), that's it. We won't spend effort fixing it anymore. But if we're releasing binaries with updated |
Would you (or one of your colleagues) have time to check Foxy and/or Galactic as well @ted-miller? |
Probably this week. |
@jimmy-mcelwain showed me his automated testing app today. It looks like it does a good job of covering (almost) all the topics, services, and action. I have asked him to go ahead and run it against a Foxy and Galactic build. |
Great. @jimmy-mcelwain: please share the results of your tests here. I'll finish the release process if things work as they should. |
@gavanderhoorn everything appears to be working as intended |
08b0591
to
93f6aa3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
It's actually ready, we'll add commits for the release proper later. Edit: @yai-rosejo: I also tagged you as you've contributed to this release. Please let me know whether you agree with the changelog additions. |
@yai-rosejo: do you have any comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Preparation for the
0.1.3
release.See discussion in Yaskawa-Global/motoros2_interfaces#20 on whether we should include #265 (and related Yaskawa-Global/motoros2_interfaces#17).