Understandable message for /reset_error if major alarm is active #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the necessary motoros2_interfaces pr |
ted-miller
reviewed
Sep 5, 2024
|
@jimmy-mcelwain I just restructured a bit for consistency with the rest of the code. |
ted-miller
previously approved these changes
Sep 5, 2024
There was a problem hiding this comment.
@jimmy-mcelwain Let me know if you have any issue with my changes. Otherwise, I think it's good
gavanderhoorn
requested changes
Sep 6, 2024
jimmy-mcelwain
requested review from
ted-miller and
gavanderhoorn
and removed request for
gavanderhoorn and
ted-miller
gavanderhoorn
approved these changes
Sep 10, 2024
|
as a final request: @jimmy-mcelwain: could you maybe squash your commits (and @ted-miller's fixup)? This change doesn't seem to need 4 commits :) |
…or, and add MotionNotReady code for major alarm to differentiate from minor alarms
jimmy-mcelwain
force-pushed
the
MajorAlarmMessage
branch
from
a717abc
to
aef5d3b
Compare
|
Thanks @jimmy-mcelwain 👍 |
|
We'll need to fix CI after Yaskawa-Global/motoros2_interfaces#23 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #181. Now if a major alarm is active upon calling
/reset_error, motoros2 will not make any effort to reset alarms, and it will give a better response message. I also added aMotionNotReadyCodefor major alarms, separating it from minor alarms.