fix(popup): Remove containerElement prop from Popper #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| ## Popper Props Update | ||
|
|
||
| We removed the `containerElement` prop from Popper component because it's no longer needed with | ||
| Fullscreen API. |
There was a problem hiding this comment.
do we have a codemod for this?
There was a problem hiding this comment.
I've checked usage of Popper, so it will be good to add codemod for making migration easier. Thanks for catching it, I'll add it
) Fixes: #1379 [category:Components] - Combined Icon Buttons with Primary, Secondary, and Tertiary buttons - Remove IconButton component - Add a new XS, L sizes - Removed the `toggled` prop when migrating over Icon Buttons - Converted `SegmentedControl` into a compound component and it no longer renders `IconButton` as children - Changed the values of `IconPosition`: `left` | `right` - > `start` | `end` - Refactored `AccentIcon`, `AppletIcon`, `Graphic`, `Icon`, `Svg`, `SystemIcon`, and `SystemIconCircle` to use create component and remove `iconRef` prop and now just pass the ref forward - Remove `dataLabel` prop from `PrimaryButton` and `SecondaryButton`
alanbsmith
added
approved
| }); | ||
|
|
||
| return root.toSource(); | ||
| } |
There was a problem hiding this comment.
thanks for adding this!
mannycarrera4
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1404
Release Note
The
containerElementprop has been removed from Popper component because It's no longer needed as Fullscreen API support implemented.