Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Popper's containerElement prop #1404

Closed
3 tasks
alanbsmith opened this issue Jan 3, 2022 · 1 comment
Closed
3 tasks

Remove Popper's containerElement prop #1404

alanbsmith opened this issue Jan 3, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@alanbsmith
Copy link
Member

💡 Suggestion

Remove Popper's containerElement prop.

Motivation

We no longer need this with Fullscreen API support introduced in #1403.

Acceptance Criteria

  • Remove the containerElement prop from Popper
  • Update documentation and examples
  • Update V7 migration guide
@alanbsmith alanbsmith added breaking-change A change that will break something for consumers p:1 7.x labels Jan 3, 2022
@alanbsmith alanbsmith added this to the 7.0.0 milestone Jan 3, 2022
@myvuuu myvuuu added the s:2 label Jan 27, 2022
@myvuuu myvuuu added the ready for review Code is ready for review label Apr 6, 2022
@jaclynjessup jaclynjessup moved this to 🆕 New in Canvas Kit Aug 5, 2022
@jaclynjessup jaclynjessup moved this from 🆕 New to ✅ Done in Canvas Kit Aug 5, 2022
@jaclynjessup
Copy link
Member

Closing was marked done Apr 27 22 in sprint

@jaclynjessup jaclynjessup removed breaking-change A change that will break something for consumers ready for review Code is ready for review labels Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants