chore: Combine Icon Buttons with Primary, Secondary and Tertiary #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 14, 2022 15:31
… mc-icon-buttons-mapping
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Co-authored-by: Nicholas Boll <[email protected]>
… mc-icon-buttons-mapping
alanbsmith
requested changes
Mar 31, 2022
modules/preview-react/breadcrumbs/lib/Breadcrumbs/Dropdown/Button.tsx
Outdated
Show resolved
Hide resolved
modules/preview-react/breadcrumbs/lib/Breadcrumbs/Dropdown/Button.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan B Smith <[email protected]>
Co-authored-by: Alan B Smith <[email protected]>
Co-authored-by: Alan B Smith <[email protected]>
Co-authored-by: Alan B Smith <[email protected]>
RayRedGoose
reviewed
Mar 31, 2022
Co-authored-by: Raisa Primerova <[email protected]>
alanbsmith
reviewed
Mar 31, 2022
alanbsmith
reviewed
Mar 31, 2022
modules/preview-react/breadcrumbs/lib/Breadcrumbs/Dropdown/Button.tsx
Outdated
Show resolved
Hide resolved
alanbsmith
approved these changes
Apr 1, 2022
alanbsmith
added
approved
mannycarrera4
added
automerge
and removed
ready for review
RayRedGoose
added a commit
that referenced
this pull request
Apr 7, 2022
* fix(popup): Remove containerElement prop from Popper * chore!: Combine Icon Buttons with Primary, Secondary and Tertiary (#1477) Fixes: #1379 [category:Components] - Combined Icon Buttons with Primary, Secondary, and Tertiary buttons - Remove IconButton component - Add a new XS, L sizes - Removed the `toggled` prop when migrating over Icon Buttons - Converted `SegmentedControl` into a compound component and it no longer renders `IconButton` as children - Changed the values of `IconPosition`: `left` | `right` - > `start` | `end` - Refactored `AccentIcon`, `AppletIcon`, `Graphic`, `Icon`, `Svg`, `SystemIcon`, and `SystemIconCircle` to use create component and remove `iconRef` prop and now just pass the ref forward - Remove `dataLabel` prop from `PrimaryButton` and `SecondaryButton` * feat(popup): Add codemod to remove containerElement prop from Popper Co-authored-by: Manuel Carrera <[email protected]> Co-authored-by: Alan B Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1379
BREAKING CHANGES
toggledprop when migrating over Icon ButtonsSegmentedControlinto a compound component and it no longer rendersIconButtonas childrenIconPosition:left|right- >start|endAccentIcon,AppletIcon,Graphic,Icon,Svg,SystemIcon, andSystemIconCircleto use create component and removeiconRefprop and now just pass the ref forwarddataLabelprop fromPrimaryButtonandSecondaryButtonChecklist