Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine Icon Buttons with Primary, Secondary, Tertiary Buttons #1379

Closed
6 tasks done
myvuuu opened this issue Dec 8, 2021 · 0 comments
Closed
6 tasks done

Combine Icon Buttons with Primary, Secondary, Tertiary Buttons #1379

myvuuu opened this issue Dec 8, 2021 · 0 comments
Assignees
@mannycarrera4
Labels
7.x breaking-change A change that will break something for consumers needs-design Extra attention from design is needed
Milestone
7.0.0

Comments

@myvuuu
Copy link
Collaborator

myvuuu commented Dec 8, 2021 •
edited by mannycarrera4
Loading

🚀 Feature Proposal

Combine the Icon Buttons with primary, secondary, and tertiary buttons.

Work to be Done:

  • Combine with primary, secondary, and tertiary buttons
  • Add a new XS, L sizes (will be part of combining the icon buttons)
  • Update components that uses CK icon buttons and repoint to the new icon only upgraded primary, secondary, tertiary buttons
  • Removing the Toggle prop (did not find any teams using it)
  • Merge Icon button docs w/ Primary/Secondary/Tertiary button docs
  • Develop a code mod to help teams repoint old icon buttons to the new icon only primary, secondary, and tertiary buttons
@myvuuu myvuuu added enhancement New feature or request breaking-change A change that will break something for consumers labels Dec 8, 2021
This was referenced Dec 8, 2021
Closed
Closed
@myvuuu myvuuu added the 7.x label Dec 8, 2021
@alanbsmith alanbsmith added this to the 7.0.0 milestone Dec 8, 2021
@myvuuu myvuuu added the p:1 label Dec 9, 2021
@myvuuu myvuuu added the needs-design Extra attention from design is needed label Dec 14, 2021
@myvuuu myvuuu mentioned this issue Jan 27, 2022
Closed
@myvuuu myvuuu added the s:13 label Feb 10, 2022
@mannycarrera4 mannycarrera4 self-assigned this Feb 11, 2022
@mannycarrera4 mannycarrera4 mentioned this issue Feb 16, 2022
Merged
5 tasks
@myvuuu myvuuu moved this to In Progress in Canvas Kit Milestone Planning Mar 10, 2022
RayRedGoose added a commit that referenced this issue Apr 7, 2022
@RayRedGoose @mannycarrera4 @alanbsmith
fix(popup): Remove containerElement prop from Popper (#1524)
5f4eca7 
* fix(popup): Remove containerElement prop from Popper

* chore!: Combine Icon Buttons with Primary, Secondary and Tertiary (#1477)

Fixes: #1379

[category:Components]

-  Combined Icon Buttons with Primary, Secondary, and Tertiary buttons
- Remove IconButton component
-  Add a new XS, L sizes
-  Removed the `toggled` prop when migrating over Icon Buttons
- Converted `SegmentedControl` into a compound component and it no longer renders `IconButton` as children
- Changed the values of `IconPosition`: `left` | `right` - > `start` | `end`
- Refactored `AccentIcon`, `AppletIcon`, `Graphic`, `Icon`, `Svg`, `SystemIcon`, and `SystemIconCircle` to use create component and remove `iconRef` prop and now just pass the ref forward
- Remove `dataLabel` prop from `PrimaryButton` and `SecondaryButton`

* feat(popup): Add codemod to remove containerElement prop from Popper

Co-authored-by: Manuel Carrera <[email protected]>
Co-authored-by: Alan B Smith <[email protected]>
Repository owner moved this from In Progress to Done in Canvas Kit Milestone Planning May 18, 2022
@jaclynjessup jaclynjessup moved this to 🆕 New in Canvas Kit Aug 5, 2022
@jaclynjessup jaclynjessup moved this from 🆕 New to ✅ Done in Canvas Kit Aug 5, 2022
@jaclynjessup jaclynjessup removed the p:1 label Aug 5, 2022
@jaclynjessup jaclynjessup removed s:13 enhancement New feature or request labels Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mannycarrera4 mannycarrera4

Labels
7.x breaking-change A change that will break something for consumers needs-design Extra attention from design is needed
Projects
Canvas Kit
Status: ✅ Done
Canvas Kit Milestone Planning
Status: Done
Milestone
7.0.0
Development

No branches or pull requests
4 participants
@alanbsmith @mannycarrera4 @jaclynjessup @myvuuu