Mobile Release v1.58.3 #34031
Merged
Mobile Release v1.58.3 #34031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olors (#33707) * Fix: Mobile - Check for undefined variables and merge user colors before parsing * Check for null values
* Remove 'BottomSheetScreen' component The 'BottomSheetScreen' component was introduced in the following commit in order to correct a render error related to the 'setIsFullScreen' method: d650b4f#diff-d16d37d09ff59dce57c087e978ac5536503cb1642ec2b0ecdba9536f5c695b95R20 The way the component's currently rendering is causing a conflict with the TextInput component, however. With this commit, the component's removed, along with the 'setIsFullScreen' method (the method will be re-introduced in the following commits). * Refactor 'setIsFullScreen' method With this commit, the 'setIsFullScreen' method is added back to the component. This time, it's added to its own separate 'useEffect' function. * Remove 'BottomSheetConsumer' 'BottomSheetConsumer' is no longer necessary as we're now using 'useContext' to pull in 'setIsFullScreen'. Further discussion here: #33845 (comment) * Refactor reference to 'children' As 'BottomSheetConsumer' was removed in 5232398, 'children' no longer needs to be returned as part of a function. In fact, this results in an error. With this commit, the function surrounding the reference to 'children' is removed.
…essing its type (#34020)
geriux
added
the
Mobile App - i.e. Android or iOS
5 tasks
fluiddot
requested review from
cameronvoell,
ellatrix and
guarani
as code owners
fluiddot
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
LGTM 🎊 !
I noticed that it includes the changes from previous betafixes 1.58.1 and 1.58.2 but that's caused due to not having the PR updated with trunk, when it gets updated we won't see those changes.
NOTE: The PR checks are not working because it's out-of-date with trunk, once this PR is ready to be merged after the GB-mobile PR gets merged, we'll check if the checks pass.
# Conflicts: # packages/react-native-aztec/package.json # packages/react-native-bridge/package.json # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release 1.58.3 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3828
Checklist:
*.native.jsfiles for terms that need renaming or removal).