Rich text - toTree - Add check in replacements before accessing its type #34020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +17 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Aug 11, 2021
fluiddot
reviewed
Aug 12, 2021
5 tasks
5 tasks
fluiddot
added a commit
that referenced
this pull request
Aug 12, 2021
* Release script: Update react-native-editor version to 1.58.0 * Release script: Update with changes from 'npm run core preios' * Add 1.58 section to changelog * Release script: Update react-native-editor version to 1.58.1 * Release script: Update with changes from 'npm run core preios' * [Mobile] - Global styles: Check for undefined values and merge user colors (#33707) * Fix: Mobile - Check for undefined variables and merge user colors before parsing * Check for null values * Update react-native-editor changelog * [RNMobile][Embed block] Disable paragraph transform (#33745) * Update react-native-editor changelog * Release script: Update react-native-editor version to 1.58.2 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix BottomSheet.SubSheet/TextInput Conflict (#33845) * Remove 'BottomSheetScreen' component The 'BottomSheetScreen' component was introduced in the following commit in order to correct a render error related to the 'setIsFullScreen' method: d650b4f#diff-d16d37d09ff59dce57c087e978ac5536503cb1642ec2b0ecdba9536f5c695b95R20 The way the component's currently rendering is causing a conflict with the TextInput component, however. With this commit, the component's removed, along with the 'setIsFullScreen' method (the method will be re-introduced in the following commits). * Refactor 'setIsFullScreen' method With this commit, the 'setIsFullScreen' method is added back to the component. This time, it's added to its own separate 'useEffect' function. * Remove 'BottomSheetConsumer' 'BottomSheetConsumer' is no longer necessary as we're now using 'useContext' to pull in 'setIsFullScreen'. Further discussion here: #33845 (comment) * Refactor reference to 'children' As 'BottomSheetConsumer' was removed in 5232398, 'children' no longer needs to be returned as part of a function. In fact, this results in an error. With this commit, the function surrounding the reference to 'children' is removed. * Update CHANGELOG * Release script: Update react-native-editor version to 1.58.3 * Release script: Update with changes from 'npm run core preios' * Rich text - toTree - Add optional chaining in replacements before accessing its type (#34020) * Update CHANGELOG * Remove CHANGELOG duplicated sections after merge Co-authored-by: Siobhan <[email protected]> Co-authored-by: Carlos Garcia <[email protected]> Co-authored-by: Ceyhun Ozugur <[email protected]> Co-authored-by: Siobhan Bamber <[email protected]>
dcalhoun
added a commit
that referenced
this pull request
Aug 13, 2021
* Release script: Update react-native-editor version to 1.59.0 * Release script: Update with changes from 'npm run core preios' * Update release notes * Release script: Update react-native-editor version to 1.59.1 * Release script: Update with changes from 'npm run core preios' * Mobile - Global styles - Add color to the list of styles to include in the filter (#34000) * Rich text - toTree - Add optional chaining in replacements before accessing its type (#34020) * Update 1.59.1 changelog * Reinstate Unreleased section of changelog Co-authored-by: jhnstn <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]>
fluiddot
added a commit
that referenced
this pull request
Aug 18, 2021
* Release script: Update react-native-editor version to 1.59.0 * Release script: Update with changes from 'npm run core preios' * Update release notes * Release script: Update react-native-editor version to 1.59.1 * Release script: Update with changes from 'npm run core preios' * Mobile - Global styles - Add color to the list of styles to include in the filter (#34000) * Rich text - toTree - Add optional chaining in replacements before accessing its type (#34020) * Update 1.59.1 changelog * Reinstate Unreleased section of changelog * Release script: Update react-native-editor version to 1.59.2 * Release script: Update with changes from 'npm run core preios' * Inserter: Prevent non-deterministic order of inserter items (#34078) * Prevent non-deterministic order of inserter items * Add block variations to getInserterItems unit test * Display core block variations before non-core blocks * Rename toTyped to groupByType * Update react-native-editor CHANGELOG * [RNMobile] Fix missing block title of core/latest-posts block (#34116) * Update react-native-editor CHANGELOG * [TEST] Use npm install in RN E2E Tests (iOS) workflow * Revert "[TEST] Use npm install in RN E2E Tests (iOS) workflow" This reverts commit 2b7e0e6. Co-authored-by: jhnstn <[email protected]> Co-authored-by: David Calhoun <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the latest mobile release, we have a current crash for users that are pasting content that includes the
Object replacement character. This PR adds a check forreplacementsbefore accessing itstype.How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).