[RNMobile][Embed block] Disable paragraph transform #33745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyhun
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
|
Pinging @illusaen, since you had worked on transforms on mobile before, do you think it would be fine in this case to disable the paragraph transform until we implement it properly for the embed block? |
fluiddot
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
LGTM 🎊 !
I noticed that the transformation to a paragraph block is being done due to the following from transform:
gutenberg/packages/block-library/src/embed/transforms.js
Lines 17 to 30 in a3720f1
So another approach could be to only disable that transform, although I verified that the other transform on that file is not being used on mobile because for this block we only allow transformations to media blocks, so it looks safe disabling altogether:
gutenberg/packages/block-library/src/embed/transforms.js
Lines 31 to 47 in a3720f1
|
LGTM although you could just remove paragraph from the supported list as well. |
illusaen
approved these changes
Jul 29, 2021
1 task
fluiddot
pushed a commit
that referenced
this pull request
Jul 30, 2021
5 tasks
fluiddot
added a commit
that referenced
this pull request
Jul 30, 2021
* Release script: Update react-native-editor version to 1.58.0 * Release script: Update with changes from 'npm run core preios' * Add 1.58 section to changelog * Release script: Update react-native-editor version to 1.58.1 * Release script: Update with changes from 'npm run core preios' * [Mobile] - Global styles: Check for undefined values and merge user colors (#33707) * Fix: Mobile - Check for undefined variables and merge user colors before parsing * Check for null values * Update react-native-editor changelog * [RNMobile][Embed block] Disable paragraph transform (#33745) * Update react-native-editor changelog Co-authored-by: Siobhan <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]> Co-authored-by: Ceyhun Ozugur <[email protected]>
SiobhyB
added a commit
that referenced
this pull request
Aug 4, 2021
* Release script: Update react-native-editor version to 1.58.0 * Release script: Update with changes from 'npm run core preios' * Add 1.58 section to changelog * Release script: Update react-native-editor version to 1.58.1 * Release script: Update with changes from 'npm run core preios' * [Mobile] - Global styles: Check for undefined values and merge user colors (#33707) * Fix: Mobile - Check for undefined variables and merge user colors before parsing * Check for null values * Update react-native-editor changelog * [RNMobile][Embed block] Disable paragraph transform (#33745) * Update react-native-editor changelog * Release script: Update react-native-editor version to 1.58.2 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix BottomSheet.SubSheet/TextInput Conflict (#33845) * Remove 'BottomSheetScreen' component The 'BottomSheetScreen' component was introduced in the following commit in order to correct a render error related to the 'setIsFullScreen' method: d650b4f#diff-d16d37d09ff59dce57c087e978ac5536503cb1642ec2b0ecdba9536f5c695b95R20 The way the component's currently rendering is causing a conflict with the TextInput component, however. With this commit, the component's removed, along with the 'setIsFullScreen' method (the method will be re-introduced in the following commits). * Refactor 'setIsFullScreen' method With this commit, the 'setIsFullScreen' method is added back to the component. This time, it's added to its own separate 'useEffect' function. * Remove 'BottomSheetConsumer' 'BottomSheetConsumer' is no longer necessary as we're now using 'useContext' to pull in 'setIsFullScreen'. Further discussion here: #33845 (comment) * Refactor reference to 'children' As 'BottomSheetConsumer' was removed in 5232398, 'children' no longer needs to be returned as part of a function. In fact, this results in an error. With this commit, the function surrounding the reference to 'children' is removed. * Update CHANGELOG * Fix merge issues with CHANGELOG Co-authored-by: Carlos Garcia <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]> Co-authored-by: Ceyhun Ozugur <[email protected]>
fluiddot
added a commit
that referenced
this pull request
Aug 12, 2021
* Release script: Update react-native-editor version to 1.58.0 * Release script: Update with changes from 'npm run core preios' * Add 1.58 section to changelog * Release script: Update react-native-editor version to 1.58.1 * Release script: Update with changes from 'npm run core preios' * [Mobile] - Global styles: Check for undefined values and merge user colors (#33707) * Fix: Mobile - Check for undefined variables and merge user colors before parsing * Check for null values * Update react-native-editor changelog * [RNMobile][Embed block] Disable paragraph transform (#33745) * Update react-native-editor changelog * Release script: Update react-native-editor version to 1.58.2 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix BottomSheet.SubSheet/TextInput Conflict (#33845) * Remove 'BottomSheetScreen' component The 'BottomSheetScreen' component was introduced in the following commit in order to correct a render error related to the 'setIsFullScreen' method: d650b4f#diff-d16d37d09ff59dce57c087e978ac5536503cb1642ec2b0ecdba9536f5c695b95R20 The way the component's currently rendering is causing a conflict with the TextInput component, however. With this commit, the component's removed, along with the 'setIsFullScreen' method (the method will be re-introduced in the following commits). * Refactor 'setIsFullScreen' method With this commit, the 'setIsFullScreen' method is added back to the component. This time, it's added to its own separate 'useEffect' function. * Remove 'BottomSheetConsumer' 'BottomSheetConsumer' is no longer necessary as we're now using 'useContext' to pull in 'setIsFullScreen'. Further discussion here: #33845 (comment) * Refactor reference to 'children' As 'BottomSheetConsumer' was removed in 5232398, 'children' no longer needs to be returned as part of a function. In fact, this results in an error. With this commit, the function surrounding the reference to 'children' is removed. * Update CHANGELOG * Release script: Update react-native-editor version to 1.58.3 * Release script: Update with changes from 'npm run core preios' * Rich text - toTree - Add optional chaining in replacements before accessing its type (#34020) * Update CHANGELOG * Remove CHANGELOG duplicated sections after merge Co-authored-by: Siobhan <[email protected]> Co-authored-by: Carlos Garcia <[email protected]> Co-authored-by: Ceyhun Ozugur <[email protected]> Co-authored-by: Siobhan Bamber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disabling paragraph transform for embed block on mobile/native as a workaround to fix wordpress-mobile/gutenberg-mobile#3762
How has this been tested?
See: wordpress-mobile/gutenberg-mobile#3762
Screenshots
N/A
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).