Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate gutenberg-mobile release 1.58.1 #16945

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Integrate gutenberg-mobile release 1.58.1 #16945

merged 3 commits into from
Jul 30, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jul 29, 2021 •
edited
Loading

Description

This PR incorporates the 1.58.1release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3769

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label Jul 29, 2021
@fluiddot fluiddot added this to the 17.9 ❄️ milestone Jul 29, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 29, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 29, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 53993. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@fluiddot fluiddot mentioned this pull request Jul 29, 2021
Merged
5 tasks
@mokagio
Copy link
Contributor

mokagio commented Jul 30, 2021

@fluiddot, just to double check, this PR is against the 17.9 release branch because it brings a mobile Gutenberg patch update which includes this fix for this crash introduced in 17.9. Right?

@fluiddot
Copy link
Contributor Author

@fluiddot, just to double check, this PR is against the 17.9 release branch because it brings a mobile Gutenberg patch update which includes this fix for this crash introduced in 17.9. Right?

Exactly, this PR brings a Gutenberg patch that includes a fix for that crash, as well as these changes.

@fluiddot fluiddot marked this pull request as ready for review July 30, 2021 08:08
@fluiddot fluiddot requested a review from SiobhyB July 30, 2021 08:08
@fluiddot fluiddot self-assigned this Jul 30, 2021
SiobhyB
SiobhyB approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, following test results at wordpress-mobile/gutenberg-mobile#3769.

@fluiddot fluiddot merged commit 8cb63d2 into release/17.9 Jul 30, 2021
@fluiddot fluiddot deleted the gutenberg/integrate_release_1.58.1 branch July 30, 2021 15:49
@mokagio mokagio mentioned this pull request Aug 2, 2021
Merged
@mokagio
Copy link
Contributor

mokagio commented Aug 2, 2021

@fluiddot this has been bundled as part of 17.9 beta 2 (17.9.0.2).

Thanks for your work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiobhyB SiobhyB SiobhyB approved these changes

Assignees

@fluiddot fluiddot

Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
17.9
Development

Successfully merging this pull request may close these issues.
3 participants
@fluiddot @mokagio @SiobhyB