-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] - Global styles - Add color to the block styles filter list #34000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Aug 11, 2021
Size Change: 0 B Total Size: 1.03 MB ℹ️ View Unchanged
|
ceyhun
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great!
dcalhoun
pushed a commit
that referenced
this pull request
Aug 12, 2021
5 tasks
dcalhoun
added a commit
that referenced
this pull request
Aug 13, 2021
* Release script: Update react-native-editor version to 1.59.0 * Release script: Update with changes from 'npm run core preios' * Update release notes * Release script: Update react-native-editor version to 1.59.1 * Release script: Update with changes from 'npm run core preios' * Mobile - Global styles - Add color to the list of styles to include in the filter (#34000) * Rich text - toTree - Add optional chaining in replacements before accessing its type (#34020) * Update 1.59.1 changelog * Reinstate Unreleased section of changelog Co-authored-by: jhnstn <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]>
fluiddot
added a commit
that referenced
this pull request
Aug 18, 2021
* Release script: Update react-native-editor version to 1.59.0 * Release script: Update with changes from 'npm run core preios' * Update release notes * Release script: Update react-native-editor version to 1.59.1 * Release script: Update with changes from 'npm run core preios' * Mobile - Global styles - Add color to the list of styles to include in the filter (#34000) * Rich text - toTree - Add optional chaining in replacements before accessing its type (#34020) * Update 1.59.1 changelog * Reinstate Unreleased section of changelog * Release script: Update react-native-editor version to 1.59.2 * Release script: Update with changes from 'npm run core preios' * Inserter: Prevent non-deterministic order of inserter items (#34078) * Prevent non-deterministic order of inserter items * Add block variations to getInserterItems unit test * Display core block variations before non-core blocks * Rename toTyped to groupByType * Update react-native-editor CHANGELOG * [RNMobile] Fix missing block title of core/latest-posts block (#34116) * Update react-native-editor CHANGELOG * [TEST] Use npm install in RN E2E Tests (iOS) workflow * Revert "[TEST] Use npm install in RN E2E Tests (iOS) workflow" This reverts commit 2b7e0e6. Co-authored-by: jhnstn <[email protected]> Co-authored-by: David Calhoun <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR
-> wordpress-mobile/gutenberg-mobile#3822Description
We recently added some filtering to prevent passing block style attributes that mobile doesn't support yet, by doing this the
color
styles were being filtered out. This PR addscolor
to the style attributes we support.How has this been tested?
Paragraph
Text color
CUSTOM
Screenshots
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).