[RNMobile] Fix crash caused by column block with padding having paragraph as a child #33782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyhun
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
|
@antonis I think Gerardo is AFK, so I've added you as a reviewer as well. |
antonis
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Great work @ceyhun 👍
I tested this on a Pixel 5 (Android 12) with the latest WordPress-Android app from develop running metro and using a JN site. I confirm that the crash was reproduced on gutenberg trunk and is fixed with the applied changes on this branch. The code changes also LGTM 🎉
|
Thanks @antonis 🙇 |
This was referenced Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wordpress-mobile/WordPress-Android#15016.
Column block has a new feature, where we can add paddings to a column block and it passes these to its child as
wrapperStyles. These paddings can have units of%as well aspx,em, etc. Since paragraph block on mobile doesn't yet support all of those units, the app crashes during layout.How has this been tested?
On web, using a self-hosted or atomic site with latest Gutenberg version.
Spacing->PaddingAlternatively you can use this HTML in the Gutenberg demo app by switching to HTML mode, pasting it and switching back to Visual mode to test:
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).