Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Cherry-pick bug fixes from Gutenberg 6.7 into WordPress 5.3 release #17951

Merged
merged 50 commits into from
Oct 15, 2019

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Oct 15, 2019

Travis should be green and @youknowriad should review all commits applied.

There were some issues applying #17696. We need to retest:

  • color pallette and z-index
  • RichText and z-index – test by checking that the toolbar of the image caption shows properly

Pinned plugins should be re-tested as well with the DropIt plugin. Check more in #17752.

jorgefilipecosta and others added 30 commits October 15, 2019 10:53
* Update dropdown menu items to match hover style in other places

* Remove focus selector from hover styles declaration
* Change z-index override logic for popovers.

* Undo gradient formatting.

* Remove import of deleted file.

* Remove empty file, fix reference to deleted zindex
#17712)

* Plugins: Ensure sidebar plugins do not get auto-closed when opened on small screens

* Tests: Add e2e test which ensures that the plugin sidebar gets operned on medium screens

* update tests due to new expectations.

With the fix implemented in the tested hook, expecations for initial state of the hook changes since the effect bails early when the current state of `isSmall` from the viewport store matches the previous state stored on the ref.

On initial render, this hook will always bail early.

I also added some inline comments to help explain what is happening in the test and what is expected.

* fix code style issue

* Add changelog entry for edit-post package
…ds (#17746)

* Scripts: Use the latest version of webpack for build and start commands

* Add changelog entry for webpack upgrade in `@wordpress/scripts`

* Update failing tests by regenerating snapshots where hashes produces by webpack changed
* Update getDerivedStateFromProps to pass back all state property changes

* Add test to check that state.opensInNewWindow is set correctly on prop change

* Rename test file
* Update mixing that sets hover style on some buttons

* Add popover hover styles to match updates from #17621
* Core Data: Fix redo behavior and expand test coverage.

* e2e test: compare text content instead of matching snapshots
* List Block: fix merging with indented list items

* Fix forward merge
* Bump plugin version to 6.6.0-rc.1

* Typewriter: use DOMRect.top to fix for Edge (#17707)

* Bump plugin version to 6.6.0

* Bugfix for wrong isObjectActive flag

Right now isObjectActive is set as true for every existed replacement.
Thats why any custom replacements has PopoverAtImage

* Bugfix for wrong isObjectActive flag

Right now isObjectActive is set as true for every existed replacement.
Thats why any custom replacements has PopoverAtImage
When toggling between Bulleted List and Numbered List, the Block Controls for List block disappears. You have to click inside the block to get them back. Ideally, the Block Controls should always be present, if the block is selected.
Left aligned blocks should not inherited "float:left" to nested blocks.

In reference to #17793
* Packages: Add information for webpack about no side effects

* Update README.md
* Redo: add failing e2e tests

* Core Data: Don't lose flattened undos when undoing before timeout.
@gziolo
Copy link
Member Author

gziolo commented Oct 15, 2019

Travis looks really bad. I will investigate.

@gziolo gziolo force-pushed the wp/trunk-6.8-release branch from ea88a42 to 59f536f Compare October 15, 2019 11:26
@gziolo
Copy link
Member Author

gziolo commented Oct 15, 2019

The color palette is broken:

Screen Shot 2019-10-15 at 13 34 09

@jorgefilipecosta - can you help investigate?

DropIt icons look good:

Screen Shot 2019-10-15 at 13 35 19

@gziolo
Copy link
Member Author

gziolo commented Oct 15, 2019

It looks like Image block preview should have the image size provided:

Screen Shot 2019-10-15 at 13 36 52

@youknowriad
Copy link
Contributor

@gziolo The image preview is a known bug, basically once the image is loaded, next time you hover, it's fixed.

noisysocks and others added 3 commits October 15, 2019 13:10
* Update 'Heading › it should correctly apply named colors' test for Twenty Twenty

* Update 'TypeWriter' tests for Twenty Twenty

* Update 'Font Size Picker › should apply a named font size using the font size input' test for Twenty Twenty

* Update 'Preview with Custom Fields enabled › displays edits to the post title and content in the preview' test for Twenty Twenty

* Fix 'Managing reusable blocks › Should import reusable blocks' test

* TypeWriter E2E tests: Use <= instead of <
There was a change to the named font sizes in twentytwenty:
WordPress/twentytwenty#764

This updates the tests to use the new value in the theme
@jorgefilipecosta
Copy link
Member

@jorgefilipecosta - can you help investigate?

I added a commit that fixes the issue, we were removing color pallete styles in a commit but in this branch, the styles are still needed.

@youknowriad youknowriad merged commit 619eff7 into wp/trunk Oct 15, 2019
@youknowriad youknowriad deleted the wp/trunk-6.8-release branch October 15, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.