-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'No Preview Available' text to the inserter preview panel #17848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the code point of view 👍 I guess we just need a UX approval now cc: @mapk, @karmatosed.
I was wondering if we should keep the rounded borders we use for previews around that message? Thoughts @mapk |
What about using the blank state being considered for block library: |
To me, a question mark implies that I have done something as a user that the system doesn't understand. That makes sense in the context of searching for something that doesn't exist. In this context though there just is not a preview - It's not changeable or fixable by the user. Put another way, there isn't any action a user can take to answer the "question" the system is posing to them. If that makes sense? If there's concensus I'm happy to implement, just my thoughts. |
Thanks, @youknowriad! Looks good! |
Fixes #17720 based on @mapk's feedback to #17740. @youknowriad feel free to use this or not, just saw your PR in the 5.3 project and thought it was something I could take off your plate.
Description
Adds "No Preview Available." in the space where a preview would display if it existed.
How has this been tested?
Open inserter, hover over a block without a preview (video, file, etc) and see that "No Preview Available" now displays
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: