Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for: "Pinned plugins menu icons are not scaled properly" #17752

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Oct 3, 2019

Description

This PR fixes #17719

Alternative to: #17722.

How has this been tested?

Web:

  • Install the dropit plugin on a local instance.
  • Check that the drop icons are sized correctly.
  • Check that the span has the correct is-small class.

Mobile

Screenshots

Screen Shot 2019-10-03 at 2 56 07 PM

@etoledom etoledom requested review from Tug and youknowriad October 3, 2019 15:01
@etoledom etoledom self-assigned this Oct 3, 2019
@etoledom etoledom marked this pull request as ready for review October 3, 2019 15:06
@gziolo gziolo added [Package] Plugins /packages/plugins [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Oct 3, 2019
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking while this was always the case in this component, I like the consistency of the <Icon> usage. Let's revert now and consider this more thoughtfully though.

@gziolo gziolo merged commit 23a7fc9 into master Oct 4, 2019
@gziolo gziolo deleted the fix/pinned-plugins-menu-icons-scale branch October 4, 2019 10:48
@youknowriad youknowriad added this to the Gutenberg 6.7 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Plugins /packages/plugins [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With Gutenberg 6.6, the pinned plugins menu icons are not scaled properly
3 participants