Try: Move figure clearing CSS to editor style. #17737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
jasmussen
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
You should try to rebase, I think e2e intermittent failures are fixed in master. |
jasmussen
force-pushed
the
try/alt-wide-fix
branch
from
2338f8d
to
e9ccfc5
Compare
|
Rebased, let's see if the checks pass. If they do, feel free to merge if I don't get to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11234. Alternative to #10228.
This PR fixes an issue where styles meant for the editor bled into the theme.
The editor has styles for alignleft, center, right, wide, fullwide. But it does not output styles for wide and fullwide to the theme itself. The idea is for theme developers to write their own
alignfullrules in the theme, and that by opting in usingadd_theme_support( 'align-wide' );, they explicitly declare to have written those rules.This is mainly because there are a million different ways to add wide alignments — negative margins, unbounded main column,
vwunits. And even then, what full-wide means can be interpreted differently by the theme, just like how TwentyNineteen interprets Align Right to pull it out of the main column.#10228, although it fixed a problem and is needed, output that fix to the style file, which outputs it on the frontend also. That was a mistake. It should be editor only.