Fix wide regression #10228
Fix wide regression #10228
Conversation
This fixes a regression where wide images would cause horizontal scrollbars. Try the demo content, for example. I will investigate why this regression happened, I suspect it was related to the side-padding normalization.
There was a problem hiding this comment.
Things looked great in my tests 👍 I'm curious about the reason of this regression and if we can fix the problem by removing/changing the rule that caused this problem instead of adding the additional rules. But given that this bug is very noticeable feel free to merge and we can iterate later if we find a better approach.
| @@ -361,6 +361,12 @@ | |||
| display: inline-flex; | |||
| } | |||
| } | |||
|
|
|||
| // This resets the intrinsic margin on the figure in wide and full-wide alignments. | |||
There was a problem hiding this comment.
Do we need to apply this rules to the wide alignment? It looks like it was working as expected before and the problem only affected full alignment.
There was a problem hiding this comment.
I didn't think we did, and of course the wide alignment won't cause a scrollbar. But it's also inaccurately represented if we don't also reset the margins there.
Oh golly, looks like it's needed even on non wide images:
One sec pushing fix.
|
Thank you Jorge for the review, but I discovered this issue was bigger than just for wide and fullwide:
it's even for normal images that are inserted. We used to simply set Requesting another review because it's a biggish change. @kjellr can you look also? |
This fixes a regression where wide images would cause horizontal scrollbars. Try the demo content in master, note that there are horizontal scrollbars. Then try this branch, note that they are gone.
The issue: the margins on the figure weren't being reset left and right on wide image.
I will investigate why this regression happened, I suspect it was related to the side-padding normalization.