Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wide regression #10228

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Fix wide regression #10228

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
597faf8
Fix wide regression
jasmussen Sep 28, 2018
1783bc8
Fix figure horizontal margin regression.
jasmussen Sep 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/editor/src/components/block-list/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,12 @@
display: inline-flex;
}
}

// This resets the intrinsic margin on the figure in wide and full-wide alignments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to apply this rules to the wide alignment? It looks like it was working as expected before and the problem only affected full alignment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think we did, and of course the wide alignment won't cause a scrollbar. But it's also inaccurately represented if we don't also reset the margins there.

Oh golly, looks like it's needed even on non wide images:

screen shot 2018-09-28 at 13 27 56

One sec pushing fix.

figure {
margin-left: 0;
margin-right: 0;
}
}

// Wide
Expand All @@ -373,7 +379,6 @@

// Full-wide
&[data-align="full"] {

// Position hover label on the right
> .editor-block-list__breadcrumb {
right: -$border-width;
Expand Down