Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] can detach blocks from a template part #42245

Open
github-actions bot opened this issue Jul 7, 2022 · 4 comments
Open

[Flaky Test] can detach blocks from a template part #42245

github-actions bot opened this issue Jul 7, 2022 · 4 comments
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

can detach blocks from a template part

Test path

/test/e2e/specs/site-editor/template-part.spec.js

Errors

[2022-07-07T18:59:43.866Z] Test passed after 1 failed attempt on trunk.
[2022-11-09T18:37:18.827Z] Test passed after 1 failed attempt on moving-available-commands-subpage.
[2023-02-15T16:42:11.214Z] Test passed after 1 failed attempt on refactor/entity-get-editor.
[2023-02-15T19:39:35.726Z] Test passed after 1 failed attempt on refactor/entity-get-editor.
[2023-03-13T09:25:40.047Z] Test passed after 1 failed attempt on update/use-select-resubscribe.
[2023-03-13T14:00:51.356Z] Test passed after 1 failed attempt on cleanup/data-private-apis-tests-fake-timers.
[2023-03-13T14:14:03.416Z] Test passed after 1 failed attempt on cleanup/unnecessary-jest-timer-declarations.
[2023-03-13T14:21:57.236Z] Test passed after 1 failed attempt on add/story-for-full-global-styles-UI.
[2023-03-13T17:55:44.009Z] Test passed after 1 failed attempt on refactor/perf-test-results-path.
[2023-03-14T02:38:59.735Z] Test passed after 1 failed attempt on add/template-description-in-navigation-sidebar.
[2023-03-15T03:35:19.632Z] Test passed after 1 failed attempt on trunk.
[2023-03-15T06:17:36.931Z] Test passed after 1 failed attempt on trunk.
[2023-03-15T17:52:21.241Z] Test passed after 1 failed attempt on update/svg-filter-frontend-output.
[2023-03-15T17:59:11.500Z] Test passed after 1 failed attempt on wp/latest.
[2023-03-15T19:41:39.174Z] Test passed after 1 failed attempt on try/modified-date-variation.
[2023-03-16T01:38:53.764Z] Test passed after 1 failed attempt on try/resizable-box-popover-for-cover-block.
[2023-03-16T06:33:35.787Z] Test passed after 1 failed attempt on trunk.
[2023-03-17T00:03:09.705Z] Test passed after 1 failed attempt on trunk.
[2023-03-17T06:32:27.056Z] Test passed after 1 failed attempt on try/affix-knob-angle-picker-control.
[2023-03-17T07:16:02.754Z] Test passed after 1 failed attempt on trunk.
[2023-03-17T11:05:31.467Z] Test passed after 1 failed attempt on rnmobile/release_1.91.0.
[2023-03-17T16:37:31.727Z] Test passed after 1 failed attempt on add/site-icon-animation-in-frame.
[2023-03-18T22:16:09.401Z] Test passed after 1 failed attempt on add/element-env.
[2023-03-19T16:00:44.555Z] Test passed after 1 failed attempt on fix/textarea-input-block.
[2023-03-20T00:19:17.780Z] Test passed after 1 failed attempt on refactor/block-json-selectors-api.
[2023-03-20T04:16:11.999Z] Test passed after 1 failed attempt on fix/heading-block-element-overrides.
[2023-03-20T06:50:22.992Z] Test passed after 1 failed attempt on add/playwright-undo.
[2023-03-20T07:39:58.983Z] Test passed after 1 failed attempt on add/playwright-undo.
[2023-03-20T11:21:21.839Z] Test passed after 1 failed attempt on fix/use-gutenberg-instead-of-core-class-templates.
[2023-03-20T14:38:32.834Z] Test passed after 1 failed attempt on fix/group-block-deprecation.
[2023-03-20T18:24:17.672Z] Test passed after 1 failed attempt on trunk.
[2023-03-20T19:42:04.408Z] Test passed after 1 failed attempt on fix/duotone-use-tag-processor.
[2023-03-21T02:15:21.063Z] Test passed after 1 failed attempt on trunk.
[2023-03-21T03:32:18.198Z] Test passed after 1 failed attempt on try/grid-layout.
[2023-03-21T11:40:01.020Z] Test passed after 1 failed attempt on fix-39946.
[2023-03-21T12:00:25.546Z] Test passed after 1 failed attempt on ts-duotone-picker.
[2023-03-21T17:20:36.772Z] Test passed after 1 failed attempt on update/remove-important-declaration-duotone.
[2023-03-22T07:36:02.787Z] Test passed after 1 failed attempt on fix/group-block-deprecation-pt2.
[2023-03-22T08:49:46.381Z] Test passed after 1 failed attempt on webfonts/fix-typos.
[2023-03-22T17:29:10.127Z] Test passed after 1 failed attempt on move-filters-out-of-colors-section.
[2023-03-22T17:30:09.210Z] Test passed after 2 failed attempts on trunk.
[2023-03-23T01:36:22.940Z] Test passed after 1 failed attempt on trunk.
[2023-03-23T02:37:00.215Z] Test passed after 1 failed attempt on rnmobile/add-reassure-pt-2.
[2023-03-23T09:57:35.970Z] Test passed after 1 failed attempt on trunk.
[2023-03-23T11:22:55.243Z] Test passed after 1 failed attempt on fix/query-list-items-styles-leak.
[2023-03-23T15:39:02.946Z] Test passed after 1 failed attempt on trunk.
[2023-03-23T19:29:53.374Z] Test passed after 1 failed attempt on build-types-components.
[2023-03-23T20:48:27.776Z] Test passed after 1 failed attempt on fix/48586.
[2023-03-24T08:06:25.427Z] Test passed after 1 failed attempt on trunk.
[2023-03-24T09:08:10.940Z] Test passed after 1 failed attempt on trunk.
[2023-03-24T11:00:03.637Z] Test passed after 1 failed attempt on try/use-dedicated-rest-to-get-nav-fallbacks.
[2023-03-26T20:47:27.248Z] Test passed after 1 failed attempt on add/more-cover-block-unit-tests.
[2023-03-27T04:41:16.215Z] Test passed after 1 failed attempt on rnmobile/add-reassure-pt-2.
[2023-03-27T09:31:58.935Z] Test passed after 1 failed attempt on add/commands.
[2023-03-27T14:33:11.279Z] Test passed after 2 failed attempts on add/shift-arrow-full-selection.
[2023-03-27T15:30:16.282Z] Test passed after 1 failed attempt on trunk.
[2023-03-27T15:44:12.871Z] Test passed after 1 failed attempt on rnmobile/support-post-request.
[2023-03-28T00:19:22.293Z] Test passed after 1 failed attempt on test/add-writing-flow-tests.
[2023-03-28T06:46:01.310Z] Test passed after 1 failed attempt on try/block-meta.
[2023-03-28T17:13:28.584Z] Test passed after 1 failed attempt on try/block-tools-marry-document-tools.
[2023-03-29T05:42:50.571Z] Test passed after 1 failed attempt on trunk.
[2023-03-29T07:13:06.559Z] Test passed after 1 failed attempt on fix/padding-visualizer-accuracy-again.
[2023-03-29T12:18:37.699Z] Test passed after 1 failed attempt on try/simple-async-block-loading.
[2023-03-29T14:08:27.693Z] Test passed after 1 failed attempt on trunk.
[2023-03-29T15:32:56.189Z] Test passed after 2 failed attempts on fix/selectors-api-use-in-duotone.
[2023-03-29T15:59:54.586Z] Test passed after 1 failed attempt on release/15.5.
[2023-03-29T17:17:39.181Z] Test passed after 1 failed attempt on fix/show-ui-to-change-custom-links-on-sidebar-navigation.
[2023-03-29T17:47:01.513Z] Test passed after 1 failed attempt on components-changelog-check.
[2023-03-29T17:58:32.123Z] Test passed after 1 failed attempt on trunk.
[2023-03-29T19:58:05.267Z] Test passed after 1 failed attempt on fix/selectors-api-use-in-duotone.
[2023-03-30T10:37:29.791Z] Test passed after 1 failed attempt on add/site-icon-animation-in-frame.
[2023-03-30T10:46:19.182Z] Test passed after 1 failed attempt on trunk.
[2023-03-30T15:01:17.165Z] Test passed after 1 failed attempt on rnmobile/release_1.92.0.
[2023-03-30T21:50:43.380Z] Test passed after 1 failed attempt on trunk.
[2023-03-31T03:01:56.566Z] Test passed after 1 failed attempt on trunk.
[2023-03-31T05:24:40.089Z] Test passed after 1 failed attempt on fix/cover-block-tests.
[2023-03-31T06:17:42.561Z] Test passed after 1 failed attempt on try/minimal-margin.
[2023-03-31T07:49:39.664Z] Test passed after 1 failed attempt on fix/template-part-variation-matching.
[2023-03-31T08:01:13.587Z] Test passed after 1 failed attempt on add/root-client-id-to-list-view.
[2023-04-01T17:44:02.599Z] Test passed after 1 failed attempt on trunk.
[2023-04-02T00:42:44.887Z] Test passed after 1 failed attempt on update/navigable-container-ts.
[2023-04-03T05:05:00.712Z] Test passed after 1 failed attempt on try/minimal-margin.
[2023-04-03T06:40:40.306Z] Test passed after 1 failed attempt on trunk.
[2023-04-03T06:43:17.400Z] Test passed after 1 failed attempt on columns/prevent-removal-column.
[2023-04-03T07:24:23.495Z] Test passed after 1 failed attempt on trunk.
[2023-04-03T08:15:45.808Z] Test passed after 1 failed attempt on try/resize-visualizer.
[2023-04-03T10:25:32.414Z] Test passed after 1 failed attempt on rnmobile/support-post-request.
[2023-04-03T18:11:15.514Z] Test passed after 1 failed attempt on try/update-edit-icon.
[2023-04-04T07:12:44.987Z] Test passed after 1 failed attempt on try/list-view-allow-drag-to-parent-level.
[2023-04-04T08:28:39.931Z] Test passed after 1 failed attempt on trunk.
[2023-04-04T14:27:53.549Z] Test passed after 1 failed attempt on add/commands.
[2023-04-04T19:54:26.242Z] Test passed after 1 failed attempt on try/drop-zone-animation.
[2023-04-05T03:32:06.091Z] Test passed after 1 failed attempt on update/list-view-aria-attributes.
[2023-04-05T05:24:18.122Z] Test passed after 1 failed attempt on update/remove-wp-block-level-preset-style-filters.
[2023-04-05T09:22:56.574Z] Test passed after 2 failed attempts on fix/border-panel-change-handling.
[2023-04-05T16:02:00.862Z] Test passed after 2 failed attempts on try/block-tools-marry-document-tools.
[2023-04-05T16:18:21.689Z] Test passed after 1 failed attempt on trunk.
[2023-04-05T16:40:54.771Z] Test passed after 1 failed attempt on feature/update-release-issue-template.
[2023-04-05T17:32:29.130Z] Test passed after 1 failed attempt on trunk.
[2023-04-06T03:08:08.522Z] Test passed after 1 failed attempt on trunk.
[2023-04-06T03:31:38.041Z] Test passed after 1 failed attempt on try/simplified-layout.
[2023-04-06T04:04:25.839Z] Test passed after 1 failed attempt on fix/image-size-controls-type-comparison.
[2023-04-06T07:16:20.372Z] Test passed after 1 failed attempt on fix/image-size-controls-type-comparison.
[2023-04-06T09:56:31.638Z] Test passed after 1 failed attempt on add/commands.
[2023-04-06T15:04:30.971Z] Test passed after 1 failed attempt on tweak/simplify-remove-block-label.
[2023-04-06T15:08:44.082Z] Test passed after 1 failed attempt on refactor/lodash-map-values-block-library.
[2023-04-06T16:34:54.434Z] Test passed after 2 failed attempts on update/navigable-container-ts.
[2023-04-06T23:23:57.440Z] Test passed after 1 failed attempt on fix/multiple-tooltips-on-navigable-toolbar.
[2023-04-07T10:14:53.603Z] Test passed after 1 failed attempt on trunk.
[2023-04-07T11:04:09.328Z] Test passed after 1 failed attempt on update/better-sidebar-close-button-labels.
[2023-04-07T19:40:05.219Z] Test passed after 2 failed attempts on publish-notices-build-types.
[2023-04-10T05:52:35.363Z] Test passed after 1 failed attempt on e2e/fix-columns-flaky.
[2023-04-10T07:07:51.857Z] Test passed after 1 failed attempt on add/image-drop-html.
[2023-04-10T11:10:53.737Z] Test passed after 1 failed attempt on fix/inbetween-inserter-rtl.
[2023-04-10T12:32:09.106Z] Test passed after 1 failed attempt on trunk.
[2023-04-10T14:52:50.870Z] Test passed after 1 failed attempt on component-changelog-check-exclude-mobile.
[2023-04-10T15:25:31.088Z] Test passed after 1 failed attempt on rnmobile/api-fetch/enable-absolute-urls-to-be-passed.
[2023-04-10T18:32:15.397Z] Test passed after 1 failed attempt on rnmobil/add-viewport-props-to-sandbox.
[2023-04-10T21:17:35.884Z] Test passed after 1 failed attempt on trunk.
[2023-04-11T00:30:22.941Z] Test passed after 1 failed attempt on trunk.
[2023-04-11T00:47:32.146Z] Test passed after 1 failed attempt on trunk.
[2023-04-11T01:19:50.798Z] Test passed after 1 failed attempt on trunk.
[2023-04-11T07:25:40.575Z] Test passed after 1 failed attempt on try/list-view-allow-drag-to-parent-level.
[2023-04-11T07:58:26.115Z] Test passed after 1 failed attempt on trunk.
[2023-04-11T10:09:08.799Z] Test passed after 1 failed attempt on remove/smart-border-behavior.
[2023-04-11T15:49:36.976Z] Test passed after 1 failed attempt on fix/clean-up-duotone-php.
[2023-04-11T17:47:23.888Z] Test passed after 1 failed attempt on refactor/core-data-group-by.
[2023-04-12T07:09:35.040Z] Test passed after 1 failed attempt on update/list-view-to-allow-drag-at-all-levels-of-block-hierarchy.
[2023-04-12T07:54:41.008Z] Test passed after 1 failed attempt on try/add-description-top-level-key.
[2023-04-12T08:05:32.845Z] Test passed after 1 failed attempt on add/role-attribute.
[2023-04-12T10:15:20.634Z] Test passed after 1 failed attempt on trunk.
[2023-04-12T10:56:27.671Z] Test passed after 1 failed attempt on try/new-template-pattern-modal.
[2023-04-12T16:32:50.121Z] Test passed after 1 failed attempt on try/block-tools-invade-document-tools.
[2023-04-12T23:29:06.820Z] Test passed after 1 failed attempt on rnmobile/feat/listen-for-save-events.
[2023-04-19T09:21:49.721Z] Test passed after 1 failed attempt on release/15.6.
[2023-04-20T02:55:58.216Z] Test passed after 1 failed attempt on release/15.6.
[2023-04-21T17:33:46.612Z] Test passed after 1 failed attempt on release/15.6.
[2023-06-08T00:01:39.092Z] Test passed after 1 failed attempt on try/adding-non-synced-pattern-to-reusable-block-cpt.
[2024-09-06T10:42:37.927Z] Test passed after 1 failed attempt on trunk.
[2024-09-06T15:47:10.273Z] Test passed after 1 failed attempt on feat/navitator-animation.
[2024-09-12T14:40:23.999Z] Test passed after 1 failed attempt on trunk.
[2024-09-18T13:10:28.794Z] Test passed after 1 failed attempt on feat/modal-exit-animation.
[2024-09-20T11:36:11.806Z] Test passed after 1 failed attempt on update/block-toolbar-edit-mode.
[2024-09-23T04:57:35.476Z] Test passed after 1 failed attempt on try/style-book-refactor-categories-and-blocks.
[2024-09-25T02:46:46.710Z] Test passed after 1 failed attempt on dataviews/pinning-poc.
[2024-09-25T19:25:27.731Z] Test passed after 1 failed attempt on wp/6.7.
[2024-09-30T05:12:00.476Z] Test passed after 1 failed attempt on fix/consistent-zoom-out-toolbars.
[2024-10-02T05:00:01.035Z] Test passed after 1 failed attempt on trunk.
[2024-10-02T14:03:20.532Z] Test passed after 1 failed attempt on fix/button-40px-customize-widgets-edit-post.
[2024-10-10T09:47:56.603Z] Test passed after 1 failed attempt on update/storybook-type-tokens.
[2024-10-18T18:39:58.362Z] Test passed after 1 failed attempt on wp/6.7.
[2024-10-21T09:52:48.487Z] Test passed after 2 failed attempts on trunk.
[2024-10-23T08:44:11.735Z] Test passed after 1 failed attempt on docs/block-bindings-first-docs.
[2024-10-26T04:30:27.867Z] Test passed after 1 failed attempt on fix/block-editor-rich-text-compiler-error.
Error: apiRequestContext.fetch: socket hang up
Call log:
  - → GET http://localhost:8889/index.php?rest_route=/wp/v2/templates
  -   user-agent: Playwright/1.48.1 (x64; ubuntu 22.04) node/20.18 CI/1
  -   accept: */*
  -   accept-encoding: gzip,deflate,br
  -   X-WP-Nonce: de15fd34e6
  -   cookie: wordpress_test_cookie=WP%20Cookie%20check; wordpress_logged_in_23778236db82f19306f247e20a353a99=admin%7C1730088948%7CynGCmD6RlAghihnUqsOd71CR3zfJnr8S5ST0l9gbCCp%7C9d488d83c9e3be53f0da25909198e5abd6cdf660f5be4876a83e3af2b23ab5d8; wp-settings-time-1=1729916298

    at RequestUtils.rest (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/rest.ts:119:39)
    at RequestUtils.deleteAllTemplates (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/templates.ts:38:31)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/template-part.spec.js:14:22
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Jul 7, 2022
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Aug 25, 2022
@github-actions github-actions bot reopened this Nov 9, 2022
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Nov 10, 2022
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 11, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022
@github-actions github-actions bot reopened this Feb 15, 2023
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Feb 16, 2023
github-actions bot referenced this issue Mar 15, 2023
…idebar (#48732)

* Add Added by description to template navigation sidebar

* Add customized string

* Rename to AddedByText

* Code review

* Keep both descriptions

* Concat descriptions

* Refactor to postType and postId

* Modify into a local hook

* Design tweaks

* Style adjustments

- increase space between icon / label
- apply rounded corners to gravatar
- colorise fallback icon

* Don't show added by active theme

---------

Co-authored-by: James Koster <[email protected]>
github-actions bot referenced this issue Mar 15, 2023
* Preferences: Remove `types` field from `package.json`

The preferences package does not actually provide any TypeScript types, nor is it written in TypeScript. Adding a `types` field incorrectly declares the opposite.

* Fix typing for persistence layer set function

---------

Co-authored-by: Daniel Richards <[email protected]>
github-actions bot referenced this issue Mar 15, 2023
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
github-actions bot referenced this issue Mar 17, 2023
As an official WordPress maintained plugin, Gutenberg is covered by the WordPress HackerOne program. This adds the information for filing security reports to the wordpress.org plugin page.
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label May 22, 2023
@github-actions github-actions bot reopened this Jun 8, 2023
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jun 8, 2023
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jul 10, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
@github-actions github-actions bot reopened this Sep 6, 2024
github-actions bot referenced this issue Sep 6, 2024
…65113)

* Block Editor: Use the tooltip from a button in 'ButtonBlockAppender'
* Remove visually hidden element

Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: tyxla <[email protected]>
github-actions bot referenced this issue Sep 12, 2024
* Add toggle when experiment active

* Add new square icon

* Use new icon

* Remove zoom out desktop 50% from device preview dropdown

* Fix console error for stroke-width to strokeWidth

---------

Co-authored-by: Jerry Jones <[email protected]>
Co-authored-by: getdave <[email protected]>
Co-authored-by: jeryj <[email protected]>
Co-authored-by: scruffian <[email protected]>
Co-authored-by: richtabor <[email protected]>
github-actions bot referenced this issue Sep 25, 2024
Look for magic wp:polyfill comments before minification.

Avoids having to configure Terser to preserve these comments, and also avoids having them in the minified JS.

Minifiers run in the processAssets hook at the
`PROCESS_ASSETS_STAGE_OPTIMIZE_SIZE` stage. If we hook at the `PROCESS_ASSETS_STAGE_OPTIMIZE_COMPATIBILITY` stage to check for the magic comments, we don't have to worry about configuring Terser to preserve them (and won't have to have them making the output slightly larger either).

---------

Co-authored-by: anomiex <[email protected]>
Co-authored-by: gziolo <[email protected]>
Co-authored-by: sirreal <[email protected]>
Co-authored-by: sgomes <[email protected]>
github-actions bot referenced this issue Oct 18, 2024
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: getdave <[email protected]>
Co-authored-by: draganescu <[email protected]>
Co-authored-by: ajlende <[email protected]>
Co-authored-by: talldan <[email protected]>
github-actions bot referenced this issue Oct 21, 2024
Co-authored-by: mattrwalker <[email protected]>
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: ciampo <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

No branches or pull requests

1 participant