LineHeightControl: Make spin buttons adjust from placeholder value #49150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
Size Change: +38 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Nice simple fix, this is testing well for me 👍
✅ + button moves up from 1.5 placeholder state
✅ - button moves down from 1.5 placeholder state
✅ works nicely in post editor and global styles
Not at all a blocker, but one thing I did notice is that if I go to click the minus button for a block where the existing (real) line height is less that 1.5, then the line-height in the editor canvas appears to jump "up" to the new value of 1.4, which might be a tiny bit unexpected if someone was trying to click - to make the line-height smaller. On balance, though, that's much less unexpected than the 0 based value prior to this PR. Quick demo of that behaviour:
LGTM! ✨
|
Appreciate the detailed and thoughtful reviews as always @andrewserong 🙇
Good point. I agree it is a smaller UX issue than it jumping to I get the suspicion ironing out this kink might fall a little into the domain of themes. With the recent access given in the block editor to the merged global styles data, we could potentially use that to set a placeholder value in the line height control closer to what's "real". There'd still be the potential for a theme-loaded stylesheet to apply a line-height independent of theme.json and global styles which would leave us back where we started. Detecting the computed line-height for the block also seem rather inaccurate and heavy-handed 🤔 As you suggested, that all might be better suited to a follow-up and shouldn't block this PR. I'll get this one merged 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48766
What?
Updates the
LineHeightControlto make adjustments via the custom spin buttons from the placeholder value rather than zero.Why?
1.5is displayed in the input, it is unexpected that the spin buttons adjust the value from zero.How?
Testing Instructions
1.6instead of0.1.1.4instead of0.Screenshots or screencast
Screen.Recording.2023-03-17.at.11.46.39.am.mp4