-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type tokens to storybook #65993
Add type tokens to storybook #65993
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I'll defer to a review from the components team if they have one.
Storybook arcana-wise, it's interesting to use HTML tables here, glad to see that working. I looked at using Markdown tables, that seems to require an extension for the moment.
Will take a look, but in the meantime, I've converted spaces to tabs to be consistent with the rest of the codebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! We can always add more context or explanations if we feel it's needed. 🚀
After addressing spacing, I also left a few minor suggestions, mostly related to syntax highlighting. Good to go after they're addressed. 👍
Co-authored-by: Marin Atanasov <[email protected]>
Thanks the for the reviews y'all.
Yeah I meant to note that. Markdown tables aren't working currently. Let's look at adding the extension separately then revisit. |
Flaky tests detected in 1b78147. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11271245984
|
* Add type tokens to storybook * Use tabs for spacing * Apply suggestions from code review Co-authored-by: Marin Atanasov <[email protected]> --------- Co-authored-by: jameskoster <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: ciampo <[email protected]>
Related to #65982.
What?
Document the recently added type tokens (#65418) in Storybook.
Why?
This makes them more discoverable and usable.
Testing Instructions
npm run storybook