-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor: Fix React Complier error for 'useEventListeners' #66495
Conversation
Size Change: +9 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
Flaky tests detected in bd7d5dc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11528788175
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…ress#66495) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: tyxla <[email protected]>
What?
Part of #61788.
PR fixes the React Compiler error for the
useEventListeners
hook.This is the same as #66460; I just realized we had two similar hooks. Otherwise, I would've fixed them together.
Why?
It's recommended to avoid reading/writing refs during the render.
How?
Correctly implement the latest ref pattern.
Testing Instructions
None. Rich Text has extensive e2e test coverage; they should catch any regression.