-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Organizes components under 'Utilities' #66210
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in 16c87c0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11386888652
|
Thank you Matt. |
Thank you! Comparing with the Sitemap I noticed |
I wasn't involved in auditing the package, but I guess we should follow the sitemap for now and include those components as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will also need to add any necessary redirects to storybook/manager-head.html
and add the Utilities
group to storybook/preview.js
, similarly to the work done in https://github.com/WordPress/gutenberg/pull/66072/files
I moved
How do we do this? I couldn't see redirects for the recently updated 'Actions' and 'Containers' categories? |
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
What?
This pull request includes changes to update the categorization of several components in the Storybook configuration. The updates involve changing the
title
and adding anid
to better reflect the components' roles as utilities.Changes to component categorization:
packages/components/src/animate/stories/index.story.tsx
: Updatedtitle
to 'Components/Utilities/Animate' and addedid
as 'components-animate'.packages/components/src/composite/stories/index.story.tsx
: Updatedtitle
to 'Components/Utilities/Composite' and addedid
as 'components-composite'.packages/components/src/disabled/stories/index.story.tsx
: Updatedtitle
to 'Components/Utilities/Disabled' and addedid
as 'components-disabled'.packages/components/src/keyboard-shortcuts/stories/index.story.tsx
: Updatedtitle
to 'Components/Utilities/KeyboardShortcuts' and addedid
as 'components-keyboardshortcuts'.packages/components/src/sandbox/stories/index.story.tsx
: Updatedtitle
to 'Components/Utilities/SandBox' and addedid
as 'components-sandbox'.Why?
This change is part of the larger Storybook Improvements and the shared Sitemap.
How?
Organizing components in to functional groups helps categorize the content and easier to navigate and understand.
Testing Instructions
npm run storybook:dev
Screenshot