Storybook: Organizes components under 'Utilities' #66210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrwalker
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 16c87c0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11386888652
|
|
Thank you Matt. |
|
Thank you! Comparing with the Sitemap I noticed |
|
I wasn't involved in auditing the package, but I guess we should follow the sitemap for now and include those components as well |
ciampo
reviewed
Oct 18, 2024
There was a problem hiding this comment.
We will also need to add any necessary redirects to storybook/manager-head.html and add the Utilities group to storybook/preview.js , similarly to the work done in https://github.com/WordPress/gutenberg/pull/66072/files
|
I moved
How do we do this? I couldn't see redirects for the recently updated 'Actions' and 'Containers' categories? |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This pull request includes changes to update the categorization of several components in the Storybook configuration. The updates involve changing the
titleand adding anidto better reflect the components' roles as utilities.Changes to component categorization:
packages/components/src/animate/stories/index.story.tsx: Updatedtitleto 'Components/Utilities/Animate' and addedidas 'components-animate'.packages/components/src/composite/stories/index.story.tsx: Updatedtitleto 'Components/Utilities/Composite' and addedidas 'components-composite'.packages/components/src/disabled/stories/index.story.tsx: Updatedtitleto 'Components/Utilities/Disabled' and addedidas 'components-disabled'.packages/components/src/keyboard-shortcuts/stories/index.story.tsx: Updatedtitleto 'Components/Utilities/KeyboardShortcuts' and addedidas 'components-keyboardshortcuts'.packages/components/src/sandbox/stories/index.story.tsx: Updatedtitleto 'Components/Utilities/SandBox' and addedidas 'components-sandbox'.Why?
This change is part of the larger Storybook Improvements and the shared Sitemap.
How?
Organizing components in to functional groups helps categorize the content and easier to navigate and understand.
Testing Instructions
npm run storybook:devScreenshot