Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Improve component organisation #66275

Closed
9 tasks done
jameskoster opened this issue Oct 21, 2024 · 9 comments
Closed
9 tasks done

Storybook: Improve component organisation #66275

jameskoster opened this issue Oct 21, 2024 · 9 comments
Assignees
Labels
Design System Issues related to the system of combining components according to best practices. Storybook Storybook and its stories for components

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Oct 21, 2024

Currently the majority of components are grouped in a single list which isn't very intuitive to navigate.

This sitemap demonstrates how we might introduce some organisation in order to improve the Storybook experience.

@jameskoster jameskoster converted this from a draft issue Oct 21, 2024
@jameskoster jameskoster added the Storybook Storybook and its stories for components label Oct 21, 2024
@Vrishabhsk
Copy link
Contributor

Hi @jameskoster 👋. Can I work on this issue?

@jameskoster
Copy link
Contributor Author

@Vrishabhsk of course :)

@hbhalodia
Copy link
Contributor

Hi @jameskoster, I have raised the PR to add the components under typography - PR - #66633

Thank You,

@hbhalodia
Copy link
Contributor

Hi @jameskoster, Had raised PR to add components under Selection & Input Category - #66635.

Thank You,

@Vrishabhsk
Copy link
Contributor

Hi @jameskoster 👋

  • The organisation of the components for Actions and Containers is already implemented
  • The only change I can see is for Actions - DropdownMenuV2 (Renamed as Menu recently) is experimental
  • Shall I put it under Actions folder under Experimental Components or let it be as it is now?

Let me know your thoughts. Thanks

@jameskoster
Copy link
Contributor Author

Shall I put it under Actions folder under Experimental Components or let it be as it is now?

Experimental > Actions > Menu seems good to me :)

@jameskoster jameskoster added the Design System Issues related to the system of combining components according to best practices. label Nov 1, 2024
@Vrishabhsk
Copy link
Contributor

Raised PR for moving Menu under Actions folder : #66680

tyxla added a commit that referenced this issue Nov 7, 2024
… - Issue #66275  (#66658)

* Group the storybook components in Navigaiton category

* Fix tabs to add inside containers and add experimental id for component

* Fix the syntax style

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: tyxla <[email protected]>
mirka added a commit that referenced this issue Nov 12, 2024
… Issue #66275 (#66657)

* Group the overlay components in storybook

* Fix the id for the experimental components

* Remove unwanted changes from the PR

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: mirka <[email protected]>
mirka added a commit that referenced this issue Nov 12, 2024
…66275 (#66633)

* Group the components in storybook based on sitemap provided

* Fix the experimental id for components in storybook

* Revert the unwanted changes in PR

* Add the missing folder on conflicts resolve

---------

Co-authored-by: Lena Morita <[email protected]>
Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: jameskoster <[email protected]>
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this issue Nov 13, 2024
… - Issue WordPress#66275  (WordPress#66658)

* Group the storybook components in Navigaiton category

* Fix tabs to add inside containers and add experimental id for component

* Fix the syntax style

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: tyxla <[email protected]>
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this issue Nov 13, 2024
… Issue WordPress#66275 (WordPress#66657)

* Group the overlay components in storybook

* Fix the id for the experimental components

* Remove unwanted changes from the PR

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: mirka <[email protected]>
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this issue Nov 13, 2024
…ordPress#66275 (WordPress#66633)

* Group the components in storybook based on sitemap provided

* Fix the experimental id for components in storybook

* Revert the unwanted changes in PR

* Add the missing folder on conflicts resolve

---------

Co-authored-by: Lena Morita <[email protected]>
Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: jameskoster <[email protected]>
mirka added a commit that referenced this issue Nov 13, 2024
…ssue #66275 (#66659)

* Group the storybook components in Layout category

* Fix the experimental component id

* Revert the unwanted changes in PR

---------

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
mirka added a commit that referenced this issue Nov 13, 2024
…ategory - Issue #66275  (#66635)

* Update the storybook components for selection and input category

* Add treeselect under selection&input category and revert experimental component change

* Fix experimental id and sort folders alphabetically

* Fix the experimental id for toggleGroupControl

* Revert changes that are not needed in PR

* Revert the missing change on conflict resolve

* Fix formatting

* Fixup (Sort experimental Actions)

* Remove unnecessary experimental Common grouping

* Remove excessive Search & Filtering grouping

---------

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
@mirka
Copy link
Member

mirka commented Nov 14, 2024

I think we're done for the scope of this issue. Thanks everyone for helping out!

@mirka mirka closed this as completed Nov 14, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to 💫 Done in Design systems — Backlog Nov 14, 2024
@tyxla
Copy link
Member

tyxla commented Nov 18, 2024

Thanks everyone, great work y'all 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System Issues related to the system of combining components according to best practices. Storybook Storybook and its stories for components
Projects
Status: 💫 Done
Development

No branches or pull requests

5 participants