Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

疑似疑問文化をsynthesis APIの直前に移動 #310

Merged
merged 2 commits into from
Jan 28, 2022
Merged

疑似疑問文化をsynthesis APIの直前に移動 #310

merged 2 commits into from
Jan 28, 2022

Conversation

Yosshi999
Copy link
Contributor

内容

Mora追加による疑似疑問文化を音声合成の直前部に移動した。
synthesis系のAPI(/synthesis, /cancellable_synthesis, /multi_synthesis, /synthesis_morphing)に影響

関連 Issue

ref. #272
#272 (comment)

スクリーンショット・動画など

懸念点

疑似疑問文化がいい感じにならなかったときユーザーによる語尾音高の調整が出来なくなった

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1757087580

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 78.246%
Totals Coverage Status
Change from base Build 1752070036: 0.1%
Covered Lines: 687
Relevant Lines: 878
💛 - Coveralls

@Yosshi999
Copy link
Contributor Author

#309 未検証

@Yosshi999 Yosshi999 requested a review from Hiroshiba January 27, 2022 15:46
@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 29 0 coverage-100%
voicevox_engine/full_context_label.py 167 5 coverage-97%
voicevox_engine/kana_parser.py 89 1 coverage-99%
voicevox_engine/model.py 71 7 coverage-90%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 148 130 coverage-12%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 47 39 coverage-17%
voicevox_engine/synthesis_engine/synthesis_engine.py 101 0 coverage-100%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 53 5 coverage-91%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 878 191 coverage-78%

@Yosshi999 Yosshi999 requested review from aoirint and takana-v January 27, 2022 15:47
takana-v
takana-v requested changes Jan 27, 2022
View reviewed changes
Copy link
Member

@takana-v takana-v left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上のIssueのバグに関してです。

run.py Show resolved Hide resolved
@Yosshi999 Yosshi999 requested a review from takana-v January 28, 2022 10:59
@Hiroshiba
Copy link
Member

おっと、未使用importがある関係でテストが落ちていますね･･･
でもそれ以外は大丈夫そうなのでマージしちゃいます！

こちらはrelease-0.10ブランチにマージさせていただきます！

@Hiroshiba Hiroshiba changed the base branch from master to release-0.10 January 28, 2022 13:01
@Hiroshiba
Copy link
Member

う･･･　よくわからないけどマージが難しそうだったので、masterにマージしてからcherry-pickします。。
修正ありがとうございました！！

@Hiroshiba Hiroshiba changed the base branch from release-0.10 to master January 28, 2022 13:02
@Hiroshiba Hiroshiba merged commit b52f541 into VOICEVOX:master Jan 28, 2022
Hiroshiba added a commit that referenced this pull request Jan 28, 2022
@Hiroshiba
#310 の追加修正
48bb841
Hiroshiba pushed a commit that referenced this pull request Jan 28, 2022
@Yosshi999 @Hiroshiba
疑似疑問文化をsynthesis APIの直前に移動 (#310)
ceef0ca 
* append interrogative mora just before synthesis

* parse_kana should not append interrogative mora
Hiroshiba added a commit that referenced this pull request Jan 28, 2022
@Hiroshiba
#310 の追加修正
f38c541
@Hiroshiba Hiroshiba mentioned this pull request Jan 28, 2022
Merged
Hiroshiba added a commit that referenced this pull request Jan 28, 2022
@Hiroshiba @Yosshi999
To 0.10.1 (#311)
5e0790c 
* 疑似疑問文化をsynthesis APIの直前に移動 (#310)

* append interrogative mora just before synthesis

* parse_kana should not append interrogative mora

* #310 の追加修正

* update doc

Co-authored-by: Yosshi999 <[email protected]>
Hiroshiba added a commit that referenced this pull request Feb 4, 2022
@Hiroshiba @takana-v @Yosshi999
0.10.4をマージ (#320)
c7cda72 
* to 0.10.preview.2

* ユーザ辞書読み込み時のWarningを修正 (#305)

* to 0.10.0 (#306)

* onnxruntimeを0.10に (#302)

* to 0.10.0

* .

* .

* To 0.10.1 (#311)

* 疑似疑問文化をsynthesis APIの直前に移動 (#310)

* append interrogative mora just before synthesis

* parse_kana should not append interrogative mora

* #310 の追加修正

* update doc

Co-authored-by: Yosshi999 <[email protected]>

* はてなマーク付きアクセント句でバグるのを修正 (#313)

* はてなマーク付きアクセント句でバグるのを修正

* ドキュメント修正

* parse_kanaの修正漏れ

* Enable interrogativeをsynthesisのみにする (#314)

* enable_interrogativeをsynthesisのみにする

* コメント移動

* to 0.10.2

* ライセンス情報を修正 (#317)

* pyopenjtalkを更新 (#319)

* コンフリクト修正ミス

Co-authored-by: takana-v <[email protected]>
Co-authored-by: Yosshi999 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Awaiting requested review from Hiroshiba

@aoirint aoirint Awaiting requested review from aoirint

@takana-v takana-v Awaiting requested review from takana-v

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yosshi999 @coveralls @Hiroshiba @takana-v