Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

疑似疑問文化をsynthesis APIの直前に移動 #310

Merged
merged 2 commits into from
Jan 28, 2022
Merged

疑似疑問文化をsynthesis APIの直前に移動 #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
266c82c
append interrogative mora just before synthesis
Yosshi999 Jan 27, 2022
b7591f3
parse_kana should not append interrogative mora
Yosshi999 Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@
)
from voicevox_engine.preset import Preset, PresetLoader
from voicevox_engine.synthesis_engine import SynthesisEngineBase, make_synthesis_engines
from voicevox_engine.synthesis_engine.synthesis_engine_base import (
adjust_interrogative_accent_phrases,
)
from voicevox_engine.utility import ConnectBase64WavesException, connect_base64_waves


Expand Down Expand Up @@ -215,7 +212,7 @@ def accent_phrases(
accent_phrases=accent_phrases, speaker_id=speaker
)

return adjust_interrogative_accent_phrases(accent_phrases)
return accent_phrases
Yosshi999 marked this conversation as resolved.
Show resolved Hide resolved
else:
return engine.create_accent_phrases(
text,
Expand Down
20 changes: 0 additions & 20 deletions test/test_kana_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,16 +441,6 @@ def a_question_mark_accent_phrases():

expected_accent_phrases = a_question_mark_accent_phrases()
expected_accent_phrases[-1].is_interrogative = True
expected_accent_phrases[-1].moras.append(
Mora(
text="ア",
consonant=None,
consonant_length=None,
vowel="a",
vowel_length=0.0,
pitch=0.0,
)
)
self._interrogative_accent_phrase_marks_base(
text="ア'？",
enable_interrogative=True,
Expand Down Expand Up @@ -519,16 +509,6 @@ def gye_gye_gye_question_mark_accent_phrases():

expected_accent_phrases = gye_gye_gye_question_mark_accent_phrases()
expected_accent_phrases[-1].is_interrogative = True
expected_accent_phrases[-1].moras.append(
Mora(
text="エ",
consonant=None,
consonant_length=None,
vowel="e",
vowel_length=0.0,
pitch=0.0,
)
)
self._interrogative_accent_phrase_marks_base(
text="ギェ'、ギェ'/ギェ'？",
enable_interrogative=True,
Expand Down
Loading