Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユーザ辞書読み込み時のWarningを修正 #305

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

takana-v
Copy link
Member

内容

現在ではパス指定があいまいなため、作業ディレクトリがVVE直下でないとエラーが出て辞書が読み込まれません。
パス指定を厳密にすることでこれを解決します。

関連 Issue

スクリーンショット・動画など

その他

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1752145674

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 93.918%

Changes Missing Coverage Covered Lines Changed/Added Lines %
voicevox_engine/full_context_label.py 4 5 80.0%
Totals Coverage Status
Change from base Build 1740697400: -0.1%
Covered Lines: 664
Relevant Lines: 707

💛 - Coveralls

@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 29 0 coverage-100%
voicevox_engine/full_context_label.py 171 6 coverage-96%
voicevox_engine/kana_parser.py 89 1 coverage-99%
voicevox_engine/model.py 71 7 coverage-90%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 4 0 coverage-100%
voicevox_engine/synthesis_engine/make_synthesis_engine.py 25 20 coverage-20%
voicevox_engine/synthesis_engine/synthesis_engine.py 101 0 coverage-100%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 49 5 coverage-90%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 707 43 coverage-94%

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit fc80fe1 into VOICEVOX:release-0.10 Jan 26, 2022
@takana-v takana-v deleted the fix-dict-warning branch January 26, 2022 17:40
Hiroshiba added a commit that referenced this pull request Feb 4, 2022
* to 0.10.preview.2

* ユーザ辞書読み込み時のWarningを修正 (#305)

* to 0.10.0 (#306)

* onnxruntimeを0.10に (#302)

* to 0.10.0

* .

* .

* To 0.10.1 (#311)

* 疑似疑問文化をsynthesis APIの直前に移動 (#310)

* append interrogative mora just before synthesis

* parse_kana should not append interrogative mora

* #310 の追加修正

* update doc

Co-authored-by: Yosshi999 <[email protected]>

* はてなマーク付きアクセント句でバグるのを修正 (#313)

* はてなマーク付きアクセント句でバグるのを修正

* ドキュメント修正

* parse_kanaの修正漏れ

* Enable interrogativeをsynthesisのみにする (#314)

* enable_interrogativeをsynthesisのみにする

* コメント移動

* to 0.10.2

* ライセンス情報を修正 (#317)

* pyopenjtalkを更新 (#319)

* コンフリクト修正ミス

Co-authored-by: takana-v <[email protected]>
Co-authored-by: Yosshi999 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants