Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

はてなマーク付きアクセント句でバグるのを修正 #313

Conversation

Hiroshiba
Copy link
Member

内容

はてなマーク付きアクセント句でバグるのを修正しました。

その他

parse_kanaはただのパーサーなので、語尾を上げるとか関係なく疑問文を正しくパースできるべきなので、そうしました。

また、 #272 の変更で、syhthesys以外でenable_疑問文が要らなくなりました。
となるといろんな部分に散らばっているenable_疑問文は想定外な挙動をする可能性があるので、この次に修正しようと思います。

どなたかみて頂けると嬉しいです・・・!

@coveralls
Copy link

coveralls commented Jan 28, 2022

Pull Request Test Coverage Report for Build 1763045383

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.935%

Totals Coverage Status
Change from base Build 1761752986: 0.0%
Covered Lines: 666
Relevant Lines: 709

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jan 28, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 29 0 coverage-100%
voicevox_engine/full_context_label.py 171 6 coverage-96%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 72 7 coverage-90%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 4 0 coverage-100%
voicevox_engine/synthesis_engine/make_synthesis_engine.py 25 20 coverage-20%
voicevox_engine/synthesis_engine/synthesis_engine.py 101 0 coverage-100%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 53 5 coverage-91%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 709 43 coverage-94%

@Hiroshiba
Copy link
Member Author

緊急マージしちゃいます!

@Hiroshiba Hiroshiba merged commit babb900 into release-0.10 Jan 28, 2022
@Hiroshiba Hiroshiba deleted the はてなマーク付きアクセント句でバグるのを修正 branch January 28, 2022 19:03
Hiroshiba added a commit that referenced this pull request Feb 4, 2022
* to 0.10.preview.2

* ユーザ辞書読み込み時のWarningを修正 (#305)

* to 0.10.0 (#306)

* onnxruntimeを0.10に (#302)

* to 0.10.0

* .

* .

* To 0.10.1 (#311)

* 疑似疑問文化をsynthesis APIの直前に移動 (#310)

* append interrogative mora just before synthesis

* parse_kana should not append interrogative mora

* #310 の追加修正

* update doc

Co-authored-by: Yosshi999 <[email protected]>

* はてなマーク付きアクセント句でバグるのを修正 (#313)

* はてなマーク付きアクセント句でバグるのを修正

* ドキュメント修正

* parse_kanaの修正漏れ

* Enable interrogativeをsynthesisのみにする (#314)

* enable_interrogativeをsynthesisのみにする

* コメント移動

* to 0.10.2

* ライセンス情報を修正 (#317)

* pyopenjtalkを更新 (#319)

* コンフリクト修正ミス

Co-authored-by: takana-v <[email protected]>
Co-authored-by: Yosshi999 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants