Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 0.4.0 #75

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Backport 0.4.0 #75

merged 2 commits into from
Jun 1, 2021

Conversation

sdiao
Copy link
Contributor

@sdiao sdiao commented Jun 1, 2021

Proposed change(s)

Backport main branch to dev after release v0.4.0

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Provide any relevant links here.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.

Test Configuration:

  • Unity Version: [e.g. Unity 2020.2.0f1]
  • Unity machine OS + version: [e.g. Windows 10]
  • ROS machine OS + version: [e.g. Ubuntu 18.04, ROS Noetic]
  • ROS–Unity communication: [e.g. Docker]

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

sdiao and others added 2 commits June 1, 2021 11:42
* Add logging dependency (#32)

* Changing yamato host flavor to large (#33)

* Amanda/read chunks (#36)

* s.send to s.sendall

* Increase default timeout

* Timeout as argument on instantiation

* Update version number (#38)

* Laurie/topic list (#41)

* Updating Contribution Content (#44)

* Contributing guidelines

* Issue templates

* PR feedback

* Updated per later changes (#45)

* Adding PR template (#46)

* One persistent connection for all messages sent to Unity

* make UnityService accessible from ros_tcp_endpoint (#49)

* Don't keep retrying on success (#50)

* Resolve conflicts for merging dev to main

* Queue module was renamed in Python 3 (#53)

* Update package.xml (#54)

* RosConnection 2.0 (#57)

* Remove outdated handshake references

* Fix sending response to unity service (#59)

* add changelog (#60)

* Forum links to README, config.yml (#61)

* Send empty message on connection start (#58)

* add test coverage for python scripts (#62)

* fix the bug (#64)

* Minor bug fixes (#65)

* Add Tests and Linter (#63)

* Add tests for tcp sender

* Add linter and pre-commit hooks

* Reformat with python black

* Add tests

* Add tests for server, client, publisher, subscriber, ros_service, unity_service, thread_pauser

* Fix pre-commit-config file name; Add client tests

* Add github workflow check

* Formatting

* Resolve conflicts (#66)

* Fix bug (#68)

* Fix bug

* Temporarily remove publisher test

Co-authored-by: Shuo Diao <[email protected]>

* update version to 0.4.0 (#69)

Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
@sdiao sdiao requested a review from peifeng-unity June 1, 2021 22:06
@sdiao sdiao merged commit 0348018 into dev Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants