Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Contribution Content #44

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Updating Contribution Content #44

merged 3 commits into from
Mar 19, 2021

Conversation

at669
Copy link
Contributor

@at669 at669 commented Mar 17, 2021 •
edited
Loading

Re: AIRO-486

  • Adding code of conduct
  • Adding contribution guidelines
  • Adding readme info on contributing, community, support
  • Updating license appendix
  • Adding bug report & feature request issue templates

Will finalize this PR before applying the finalized versions to the other repositories.

Remaining TODO: CLA

mrpropellers
mrpropellers suggested changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@mrpropellers mrpropellers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing on this long-overdue work! Left a few comments, and I'm going to do some investigation into the granularity of Yamato's trigger filters to get a better sense of what our CI rules should be.

CONTRIBUTING.md
Comment on lines +39 to +41
<!-- ## Continuous Integration (CI)

We run continuous integration on all PRs; all tests must be passing before the PR is merged. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to be looking into whether or not it's possible to run CI before merges in the case where we get a PR from someone not on the code owner's list. In cases where we can't follow up easily with the submitter if the code breaks dev after merge, we really want to be confident that the tests are going to pass before it goes in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's no way to change test behavior based on the actual submitter. I think the best we can do is change it to run CI on every PR submission and give code owners the right to over-ride the status check on as as-needed basis.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@at669 at669 merged commit aa96e20 into dev Mar 19, 2021
@at669 at669 deleted the amanda/contributions branch March 19, 2021 21:09
LaurieCheers-unity added a commit that referenced this pull request Apr 21, 2021
@LaurieCheers-unity @prothen
@mrpropellers @at669 @hyounesy @peifeng-unity
Merge 0.3.0 to main (#55)
a5e0fd1 
* Add logging dependency (#32)

* Changing yamato host flavor to large (#33)

* Amanda/read chunks (#36)

* s.send to s.sendall

* Increase default timeout

* Timeout as argument on instantiation

* Update version number (#38)

* Laurie/topic list (#41)

* Updating Contribution Content (#44)

* Contributing guidelines

* Issue templates

* PR feedback

* Updated per later changes (#45)

* Adding PR template (#46)

* One persistent connection for all messages sent to Unity

* make UnityService accessible from ros_tcp_endpoint (#49)

* Don't keep retrying on success (#50)

* Resolve conflicts for merging dev to main

* Queue module was renamed in Python 3 (#53)

* Update package.xml (#54)

Co-authored-by: Philipp Rothenhäusler <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
sdiao pushed a commit that referenced this pull request May 27, 2021
@at669 @sdiao
Updating Contribution Content (#44)
b7222a6 
* Contributing guidelines

* Issue templates

* PR feedback
sdiao added a commit that referenced this pull request Jun 1, 2021
@sdiao @mrpropellers
@at669 @LaurieCheers-unity @hyounesy @peifeng-unity
Merge Dev to main for release 0.4.0 (#74)
18612dc 
* Add logging dependency (#32)

* Changing yamato host flavor to large (#33)

* Amanda/read chunks (#36)

* s.send to s.sendall

* Increase default timeout

* Timeout as argument on instantiation

* Update version number (#38)

* Laurie/topic list (#41)

* Updating Contribution Content (#44)

* Contributing guidelines

* Issue templates

* PR feedback

* Updated per later changes (#45)

* Adding PR template (#46)

* One persistent connection for all messages sent to Unity

* make UnityService accessible from ros_tcp_endpoint (#49)

* Don't keep retrying on success (#50)

* Resolve conflicts for merging dev to main

* Queue module was renamed in Python 3 (#53)

* Update package.xml (#54)

* RosConnection 2.0 (#57)

* Remove outdated handshake references

* Fix sending response to unity service (#59)

* add changelog (#60)

* Forum links to README, config.yml (#61)

* Send empty message on connection start (#58)

* add test coverage for python scripts (#62)

* fix the bug (#64)

* Minor bug fixes (#65)

* Add Tests and Linter (#63)

* Add tests for tcp sender

* Add linter and pre-commit hooks

* Reformat with python black

* Add tests

* Add tests for server, client, publisher, subscriber, ros_service, unity_service, thread_pauser

* Fix pre-commit-config file name; Add client tests

* Add github workflow check

* Formatting

* Resolve conflicts (#66)

* Fix bug (#68)

* Fix bug

* Temporarily remove publisher test

Co-authored-by: Shuo Diao <[email protected]>

* update version to 0.4.0 (#69)

Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
sdiao added a commit that referenced this pull request Jun 1, 2021
@sdiao @mrpropellers
@at669 @LaurieCheers-unity @hyounesy @peifeng-unity
Merge Dev to main for release 0.4.0 (#74) (#75)
0348018 
* Add logging dependency (#32)

* Changing yamato host flavor to large (#33)

* Amanda/read chunks (#36)

* s.send to s.sendall

* Increase default timeout

* Timeout as argument on instantiation

* Update version number (#38)

* Laurie/topic list (#41)

* Updating Contribution Content (#44)

* Contributing guidelines

* Issue templates

* PR feedback

* Updated per later changes (#45)

* Adding PR template (#46)

* One persistent connection for all messages sent to Unity

* make UnityService accessible from ros_tcp_endpoint (#49)

* Don't keep retrying on success (#50)

* Resolve conflicts for merging dev to main

* Queue module was renamed in Python 3 (#53)

* Update package.xml (#54)

* RosConnection 2.0 (#57)

* Remove outdated handshake references

* Fix sending response to unity service (#59)

* add changelog (#60)

* Forum links to README, config.yml (#61)

* Send empty message on connection start (#58)

* add test coverage for python scripts (#62)

* fix the bug (#64)

* Minor bug fixes (#65)

* Add Tests and Linter (#63)

* Add tests for tcp sender

* Add linter and pre-commit hooks

* Reformat with python black

* Add tests

* Add tests for server, client, publisher, subscriber, ros_service, unity_service, thread_pauser

* Fix pre-commit-config file name; Add client tests

* Add github workflow check

* Formatting

* Resolve conflicts (#66)

* Fix bug (#68)

* Fix bug

* Temporarily remove publisher test

Co-authored-by: Shuo Diao <[email protected]>

* update version to 0.4.0 (#69)

Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>

Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
peifeng-unity pushed a commit that referenced this pull request Jul 15, 2021
@at669 @peifeng-unity
Updating Contribution Content (#44)
3da0865 
* Contributing guidelines

* Issue templates

* PR feedback
LaurieCheers-unity added a commit that referenced this pull request Sep 29, 2021
@at669 @sdiao
@mrpropellers @LaurieCheers-unity @hyounesy @peifeng-unity @tiffanyyk @P3TE
ROS2-Side Updates (#94)
da13e9b 
* Merge Dev to main for release 0.4.0 (#74)

* Add logging dependency (#32)

* Changing yamato host flavor to large (#33)

* Amanda/read chunks (#36)

* s.send to s.sendall

* Increase default timeout

* Timeout as argument on instantiation

* Update version number (#38)

* Laurie/topic list (#41)

* Updating Contribution Content (#44)

* Contributing guidelines

* Issue templates

* PR feedback

* Updated per later changes (#45)

* Adding PR template (#46)

* One persistent connection for all messages sent to Unity

* make UnityService accessible from ros_tcp_endpoint (#49)

* Don't keep retrying on success (#50)

* Resolve conflicts for merging dev to main

* Queue module was renamed in Python 3 (#53)

* Update package.xml (#54)

* RosConnection 2.0 (#57)

* Remove outdated handshake references

* Fix sending response to unity service (#59)

* add changelog (#60)

* Forum links to README, config.yml (#61)

* Send empty message on connection start (#58)

* add test coverage for python scripts (#62)

* fix the bug (#64)

* Minor bug fixes (#65)

* Add Tests and Linter (#63)

* Add tests for tcp sender

* Add linter and pre-commit hooks

* Reformat with python black

* Add tests

* Add tests for server, client, publisher, subscriber, ros_service, unity_service, thread_pauser

* Fix pre-commit-config file name; Add client tests

* Add github workflow check

* Formatting

* Resolve conflicts (#66)

* Fix bug (#68)

* Fix bug

* Temporarily remove publisher test

Co-authored-by: Shuo Diao <[email protected]>

* update version to 0.4.0 (#69)

Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>

* ROS2 support (#77)

Co-authored-by: Tiffany Yau <[email protected]>

* update changelog (#83)

* Merge v0.5.0 (#84)

* Merge main to dev (#85)

* Stale issue handler (#87)

* Initial commit: stale handler

* Remove latest tag from yamato config

* Updated dates, changelog

* PR Feedback: cron schedule

* Exposing publisher queue_size and latch (#88)

* Working to improve the ROS TCP connector by adding queues and latching.

* Exposing the latch parameter for ROS publishers.

* Updating the CHANGELOG

* Improving style for publish method definition.

* Improving the performance of the read_message by not splitting the da… (#90)

* Improving the performance of the read_message by not splitting the data into 1024 chunks and stitching them together as you go, instead receiving the entire message all at once.

* Updating the changelog

* Publisher signature

* Publisher constructor

* Don't mess around with packets, just read the whole message

* source_destination_dict shatters into 4 separate tables

* Update tests

* 1 more test fix

* Updated server, setup dir

Co-authored-by: Shuo Diao <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: Tiffany Yau <[email protected]>
Co-authored-by: Peter Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpropellers mrpropellers mrpropellers approved these changes

@mpinol mpinol Awaiting requested review from mpinol

@sarah-gibson sarah-gibson Awaiting requested review from sarah-gibson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@at669 @mrpropellers