Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laurie/topic list #41

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Laurie/topic list #41

merged 4 commits into from
Mar 12, 2021

Conversation

LaurieCheers-unity
Copy link
Contributor

Endpoint-side implementation of Unity-Technologies/ROS-TCP-Connector#72

mpinol
mpinol reviewed Mar 12, 2021
View reviewed changes
src/ros_tcp_endpoint/server.py
@@ -96,6 +97,9 @@ def send_unity_message(self, topic, message):
def send_unity_service(self, topic, service_class, request):
return self.unity_tcp_sender.send_unity_service(topic, service_class, request)

def topic_list(self, data):
return RosUnityTopicListResponse(self.source_destination_dict.keys())
Copy link
Contributor

@mpinol mpinol Mar 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the best example but wouldn't the source dest dict below be valid?

tcp_server.start({
    'robot_pos_rot': RosPublisher('pos_rot', PosRot, queue_size=10),
    'robot_pos_rot_mapper': RosSubscriber('pos_rot', PosRot, tcp_server)
})

In that case it might be better to do something like,

[x.topic for x in self.source_destination_dict.values() ]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh... if that's supposed to be valid (and I'm not sure it is), I don't understand why we're using a dict at all?

mpinol
mpinol reviewed Mar 12, 2021
View reviewed changes
src/ros_tcp_endpoint/client.py
@@ -102,7 +102,7 @@ def read_message(conn):

data += packet

if not data:
if full_message_size > 0 and not data:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this necessary because your service does not have a Request message type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My service's request type is empty, yes. And there are plenty of preexisting services like that, so we should handle them :-)

@LaurieCheers-unity LaurieCheers-unity merged commit 97bb44e into dev Mar 12, 2021
@LaurieCheers-unity LaurieCheers-unity deleted the laurie/TopicList branch March 12, 2021 19:25
LaurieCheers-unity added a commit that referenced this pull request Apr 21, 2021
@LaurieCheers-unity @prothen
@mrpropellers @at669 @hyounesy @peifeng-unity
Merge 0.3.0 to main (#55)
a5e0fd1 
* Add logging dependency (#32)

* Changing yamato host flavor to large (#33)

* Amanda/read chunks (#36)

* s.send to s.sendall

* Increase default timeout

* Timeout as argument on instantiation

* Update version number (#38)

* Laurie/topic list (#41)

* Updating Contribution Content (#44)

* Contributing guidelines

* Issue templates

* PR feedback

* Updated per later changes (#45)

* Adding PR template (#46)

* One persistent connection for all messages sent to Unity

* make UnityService accessible from ros_tcp_endpoint (#49)

* Don't keep retrying on success (#50)

* Resolve conflicts for merging dev to main

* Queue module was renamed in Python 3 (#53)

* Update package.xml (#54)

Co-authored-by: Philipp Rothenhäusler <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
sdiao pushed a commit that referenced this pull request May 27, 2021
@LaurieCheers-unity @sdiao
Laurie/topic list (#41)
6db3ee4
sdiao added a commit that referenced this pull request Jun 1, 2021
@sdiao @mrpropellers
@at669 @LaurieCheers-unity @hyounesy @peifeng-unity
Merge Dev to main for release 0.4.0 (#74)
18612dc 
* Add logging dependency (#32)

* Changing yamato host flavor to large (#33)

* Amanda/read chunks (#36)

* s.send to s.sendall

* Increase default timeout

* Timeout as argument on instantiation

* Update version number (#38)

* Laurie/topic list (#41)

* Updating Contribution Content (#44)

* Contributing guidelines

* Issue templates

* PR feedback

* Updated per later changes (#45)

* Adding PR template (#46)

* One persistent connection for all messages sent to Unity

* make UnityService accessible from ros_tcp_endpoint (#49)

* Don't keep retrying on success (#50)

* Resolve conflicts for merging dev to main

* Queue module was renamed in Python 3 (#53)

* Update package.xml (#54)

* RosConnection 2.0 (#57)

* Remove outdated handshake references

* Fix sending response to unity service (#59)

* add changelog (#60)

* Forum links to README, config.yml (#61)

* Send empty message on connection start (#58)

* add test coverage for python scripts (#62)

* fix the bug (#64)

* Minor bug fixes (#65)

* Add Tests and Linter (#63)

* Add tests for tcp sender

* Add linter and pre-commit hooks

* Reformat with python black

* Add tests

* Add tests for server, client, publisher, subscriber, ros_service, unity_service, thread_pauser

* Fix pre-commit-config file name; Add client tests

* Add github workflow check

* Formatting

* Resolve conflicts (#66)

* Fix bug (#68)

* Fix bug

* Temporarily remove publisher test

Co-authored-by: Shuo Diao <[email protected]>

* update version to 0.4.0 (#69)

Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
sdiao added a commit that referenced this pull request Jun 1, 2021
@sdiao @mrpropellers
@at669 @LaurieCheers-unity @hyounesy @peifeng-unity
Merge Dev to main for release 0.4.0 (#74) (#75)
0348018 
* Add logging dependency (#32)

* Changing yamato host flavor to large (#33)

* Amanda/read chunks (#36)

* s.send to s.sendall

* Increase default timeout

* Timeout as argument on instantiation

* Update version number (#38)

* Laurie/topic list (#41)

* Updating Contribution Content (#44)

* Contributing guidelines

* Issue templates

* PR feedback

* Updated per later changes (#45)

* Adding PR template (#46)

* One persistent connection for all messages sent to Unity

* make UnityService accessible from ros_tcp_endpoint (#49)

* Don't keep retrying on success (#50)

* Resolve conflicts for merging dev to main

* Queue module was renamed in Python 3 (#53)

* Update package.xml (#54)

* RosConnection 2.0 (#57)

* Remove outdated handshake references

* Fix sending response to unity service (#59)

* add changelog (#60)

* Forum links to README, config.yml (#61)

* Send empty message on connection start (#58)

* add test coverage for python scripts (#62)

* fix the bug (#64)

* Minor bug fixes (#65)

* Add Tests and Linter (#63)

* Add tests for tcp sender

* Add linter and pre-commit hooks

* Reformat with python black

* Add tests

* Add tests for server, client, publisher, subscriber, ros_service, unity_service, thread_pauser

* Fix pre-commit-config file name; Add client tests

* Add github workflow check

* Formatting

* Resolve conflicts (#66)

* Fix bug (#68)

* Fix bug

* Temporarily remove publisher test

Co-authored-by: Shuo Diao <[email protected]>

* update version to 0.4.0 (#69)

Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>

Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
peifeng-unity pushed a commit that referenced this pull request Jul 15, 2021
@LaurieCheers-unity @peifeng-unity
Laurie/topic list (#41)
c73fe13
LaurieCheers-unity added a commit that referenced this pull request Sep 29, 2021
@at669 @sdiao
@mrpropellers @LaurieCheers-unity @hyounesy @peifeng-unity @tiffanyyk @P3TE
ROS2-Side Updates (#94)
da13e9b 
* Merge Dev to main for release 0.4.0 (#74)

* Add logging dependency (#32)

* Changing yamato host flavor to large (#33)

* Amanda/read chunks (#36)

* s.send to s.sendall

* Increase default timeout

* Timeout as argument on instantiation

* Update version number (#38)

* Laurie/topic list (#41)

* Updating Contribution Content (#44)

* Contributing guidelines

* Issue templates

* PR feedback

* Updated per later changes (#45)

* Adding PR template (#46)

* One persistent connection for all messages sent to Unity

* make UnityService accessible from ros_tcp_endpoint (#49)

* Don't keep retrying on success (#50)

* Resolve conflicts for merging dev to main

* Queue module was renamed in Python 3 (#53)

* Update package.xml (#54)

* RosConnection 2.0 (#57)

* Remove outdated handshake references

* Fix sending response to unity service (#59)

* add changelog (#60)

* Forum links to README, config.yml (#61)

* Send empty message on connection start (#58)

* add test coverage for python scripts (#62)

* fix the bug (#64)

* Minor bug fixes (#65)

* Add Tests and Linter (#63)

* Add tests for tcp sender

* Add linter and pre-commit hooks

* Reformat with python black

* Add tests

* Add tests for server, client, publisher, subscriber, ros_service, unity_service, thread_pauser

* Fix pre-commit-config file name; Add client tests

* Add github workflow check

* Formatting

* Resolve conflicts (#66)

* Fix bug (#68)

* Fix bug

* Temporarily remove publisher test

Co-authored-by: Shuo Diao <[email protected]>

* update version to 0.4.0 (#69)

Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>

* ROS2 support (#77)

Co-authored-by: Tiffany Yau <[email protected]>

* update changelog (#83)

* Merge v0.5.0 (#84)

* Merge main to dev (#85)

* Stale issue handler (#87)

* Initial commit: stale handler

* Remove latest tag from yamato config

* Updated dates, changelog

* PR Feedback: cron schedule

* Exposing publisher queue_size and latch (#88)

* Working to improve the ROS TCP connector by adding queues and latching.

* Exposing the latch parameter for ROS publishers.

* Updating the CHANGELOG

* Improving style for publish method definition.

* Improving the performance of the read_message by not splitting the da… (#90)

* Improving the performance of the read_message by not splitting the data into 1024 chunks and stitching them together as you go, instead receiving the entire message all at once.

* Updating the changelog

* Publisher signature

* Publisher constructor

* Don't mess around with packets, just read the whole message

* source_destination_dict shatters into 4 separate tables

* Update tests

* 1 more test fix

* Updated server, setup dir

Co-authored-by: Shuo Diao <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: Tiffany Yau <[email protected]>
Co-authored-by: Peter Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpinol mpinol mpinol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LaurieCheers-unity @mpinol